diff mbox

DMA: shdma: r8a73a4: Make dma_ts_shift[] static

Message ID 1432209510-20449-1-git-send-email-geert+renesas@glider.be (mailing list archive)
State Accepted
Headers show

Commit Message

Geert Uytterhoeven May 21, 2015, 11:58 a.m. UTC
dma_ts_shift[] isn't used outside this source file. All other users use
the definition from arch/arm/mach-shmobile/dma-register.h.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/dma/sh/shdma-r8a73a4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman May 22, 2015, 1:26 a.m. UTC | #1
On Thu, May 21, 2015 at 01:58:30PM +0200, Geert Uytterhoeven wrote:
> dma_ts_shift[] isn't used outside this source file. All other users use
> the definition from arch/arm/mach-shmobile/dma-register.h.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  drivers/dma/sh/shdma-r8a73a4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/sh/shdma-r8a73a4.c b/drivers/dma/sh/shdma-r8a73a4.c
> index 4fb99970a3ea9b56..96ea3828c3eb8213 100644
> --- a/drivers/dma/sh/shdma-r8a73a4.c
> +++ b/drivers/dma/sh/shdma-r8a73a4.c
> @@ -11,7 +11,7 @@
>  
>  #include "shdma-arm.h"
>  
> -const unsigned int dma_ts_shift[] = SH_DMAE_TS_SHIFT;
> +static const unsigned int dma_ts_shift[] = SH_DMAE_TS_SHIFT;
>  
>  static const struct sh_dmae_slave_config dma_slaves[] = {
>  	{
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vinod Koul May 25, 2015, 5:03 p.m. UTC | #2
On Thu, May 21, 2015 at 01:58:30PM +0200, Geert Uytterhoeven wrote:
> dma_ts_shift[] isn't used outside this source file. All other users use
> the definition from arch/arm/mach-shmobile/dma-register.h.
Applied, thanks
diff mbox

Patch

diff --git a/drivers/dma/sh/shdma-r8a73a4.c b/drivers/dma/sh/shdma-r8a73a4.c
index 4fb99970a3ea9b56..96ea3828c3eb8213 100644
--- a/drivers/dma/sh/shdma-r8a73a4.c
+++ b/drivers/dma/sh/shdma-r8a73a4.c
@@ -11,7 +11,7 @@ 
 
 #include "shdma-arm.h"
 
-const unsigned int dma_ts_shift[] = SH_DMAE_TS_SHIFT;
+static const unsigned int dma_ts_shift[] = SH_DMAE_TS_SHIFT;
 
 static const struct sh_dmae_slave_config dma_slaves[] = {
 	{