From patchwork Tue Nov 24 02:20:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 7687261 Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 485749F4F5 for ; Tue, 24 Nov 2015 02:21:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 652CA2086F for ; Tue, 24 Nov 2015 02:21:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64D3320843 for ; Tue, 24 Nov 2015 02:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752566AbbKXCVB (ORCPT ); Mon, 23 Nov 2015 21:21:01 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:48536 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbbKXCVA (ORCPT ); Mon, 23 Nov 2015 21:21:00 -0500 Received: from reginn.isobedori.kobe.vergenet.net (p5254-ipbfp1403kobeminato.hyogo.ocn.ne.jp [114.152.48.254]) by kirsty.vergenet.net (Postfix) with ESMTPA id B72A325B7AB; Tue, 24 Nov 2015 13:20:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1448331658; bh=QZefTcZfImCJFRAY/EE32JE46BkexZfjOwIImTD1ZAc=; h=From:To:Cc:Subject:Date:From; b=OENKPAn6FAExsmV+gpdc1dOnBFyPS69fGTDPqeszhEbYPdmux2bQ4HlvpYwxGWvYJ GwyHUgPnjCtkHFBnOL1hYQ+nT4q+376wEW7turoa/3GU/ZQT9xxcFMgszV3i3ZG7+o 4BQxCPrTnqHFdXx2NlSzQrv0jsGs97Pz8Gdq3mto= Received: by reginn.isobedori.kobe.vergenet.net (Postfix, from userid 7100) id 73140940534; Tue, 24 Nov 2015 11:20:57 +0900 (JST) From: Simon Horman To: Vinod Koul Cc: dmaengine@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , devicetree@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH] dmaengine: usb-dmac: Document SoC specific bindings Date: Tue, 24 Nov 2015 11:20:41 +0900 Message-Id: <1448331641-21758-1-git-send-email-horms+renesas@verge.net.au> X-Mailer: git-send-email 2.1.4 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted. Although not universally liked this convention is used in the bindings for most drivers for Renesas hardware. The purpose of this patch is to update the Renesas USB DMA Controller driver to follow this convention. Cc: devicetree@vger.kernel.org Cc: Yoshihiro Shimoda Signed-off-by: Simon Horman Acked-by: Yoshihiro Shimoda Acked-by: Rob Herring --- * r8a7792 (R-Car V2H) is omitted as my reading of the documentation is that Renesas USB-DMAC does not exist on that SoC * r8a7795 (R-Car H2) is omitted as its unclear to me on the compatibility of USB-DMAC that SoC * Once this has been merged I intend to provide follow-up patches to use these new compat strings in the relevant dtsi files. --- Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt index 040f365954cc..3bb624e10615 100644 --- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt +++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt @@ -1,7 +1,12 @@ * Renesas USB DMA Controller Device Tree bindings Required Properties: -- compatible: must contain "renesas,usb-dmac" +- compatible: "renesas,usb-dmac-", "renesas,usb-dmac" as fallback. + Examples with soctypes are: + - "renesas,usb-dmac-r8a7790" (R-Car H2) + - "renesas,usb-dmac-r8a7791" (R-Car M2-W) + - "renesas,usb-dmac-r8a7793" (R-Car M2-N) + - "renesas,usb-dmac-r8a7794" (R-Car E2) - reg: base address and length of the registers block for the DMAC - interrupts: interrupt specifiers for the DMAC, one for each entry in interrupt-names. @@ -15,7 +20,7 @@ Required Properties: Example: R8A7790 (R-Car H2) USB-DMACs usb_dmac0: dma-controller@e65a0000 { - compatible = "renesas,usb-dmac"; + compatible = "renesas,usb-dmac-r8a7790", "renesas,usb-dmac"; reg = <0 0xe65a0000 0 0x100>; interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH 0 109 IRQ_TYPE_LEVEL_HIGH>;