| Message ID | 1619170187-5552-1-git-send-email-yibin.gong@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] dmaengine: fsl-qdma: check dma_set_mask return value | expand |
On 23-04-21, 17:29, Robin Gong wrote: > For fix warning reported by static code analysis tool like Coverity from > Synopsys. Please mention which warning, also Coverity id Do see other patches which add coverity ids > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > --- > drivers/dma/fsl-qdma.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c > index ed2ab46..86c02b6 100644 > --- a/drivers/dma/fsl-qdma.c > +++ b/drivers/dma/fsl-qdma.c > @@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct platform_device *pdev) > fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize; > fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all; > > - dma_set_mask(&pdev->dev, DMA_BIT_MASK(40)); > + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(40)); > + if (ret) { > + dev_err(&pdev->dev, "dma_set_mask failure.\n"); > + return ret; > + } > > platform_set_drvdata(pdev, fsl_qdma); > > -- > 2.7.4
On 2021/04/26 Vinod Koul <vkoul@kernel.org> wrote: > On 23-04-21, 17:29, Robin Gong wrote: > > For fix warning reported by static code analysis tool like Coverity > > from Synopsys. > > Please mention which warning, also Coverity id Do see other patches which > add coverity ids > Okay, would add it in v3, thanks. > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > > --- > > drivers/dma/fsl-qdma.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index > > ed2ab46..86c02b6 100644 > > --- a/drivers/dma/fsl-qdma.c > > +++ b/drivers/dma/fsl-qdma.c > > @@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct > platform_device *pdev) > > fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize; > > fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all; > > > > - dma_set_mask(&pdev->dev, DMA_BIT_MASK(40)); > > + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(40)); > > + if (ret) { > > + dev_err(&pdev->dev, "dma_set_mask failure.\n"); > > + return ret; > > + } > > > > platform_set_drvdata(pdev, fsl_qdma); > > > > -- > > 2.7.4 > > -- > ~Vinod
diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index ed2ab46..86c02b6 100644 --- a/drivers/dma/fsl-qdma.c +++ b/drivers/dma/fsl-qdma.c @@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct platform_device *pdev) fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize; fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all; - dma_set_mask(&pdev->dev, DMA_BIT_MASK(40)); + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(40)); + if (ret) { + dev_err(&pdev->dev, "dma_set_mask failure.\n"); + return ret; + } platform_set_drvdata(pdev, fsl_qdma);
For fix warning reported by static code analysis tool like Coverity from Synopsys. Signed-off-by: Robin Gong <yibin.gong@nxp.com> --- drivers/dma/fsl-qdma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)