diff mbox series

dmaengine: idxd: clear block on fault flag when clear wq

Message ID 162803023553.3086015.8158952172068868803.stgit@djiang5-desk3.ch.intel.com (mailing list archive)
State Accepted
Headers show
Series dmaengine: idxd: clear block on fault flag when clear wq | expand

Commit Message

Dave Jiang Aug. 3, 2021, 10:37 p.m. UTC
The block on fault flag is not cleared when we disable or reset wq. This
causes it to remain set if the user does not clear it on the next
configuration load. Add clear of flag in dxd_wq_disable_cleanup()
routine.

Fixes: da32b28c95a7 ("dmaengine: idxd: cleanup workqueue config after disabling")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/idxd/device.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul Aug. 6, 2021, 1:53 p.m. UTC | #1
On 03-08-21, 15:37, Dave Jiang wrote:
> The block on fault flag is not cleared when we disable or reset wq. This
> causes it to remain set if the user does not clear it on the next
> configuration load. Add clear of flag in dxd_wq_disable_cleanup()
> routine.

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 420b93fe5feb..d0b5222da0d9 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -396,6 +396,7 @@  void idxd_wq_disable_cleanup(struct idxd_wq *wq)
 	wq->priority = 0;
 	wq->ats_dis = 0;
 	clear_bit(WQ_FLAG_DEDICATED, &wq->flags);
+	clear_bit(WQ_FLAG_BLOCK_ON_FAULT, &wq->flags);
 	memset(wq->name, 0, WQ_NAME_SIZE);
 }