diff mbox series

dmaengine: idxd: remove trailing white space on input str for wq name

Message ID 164789525123.2799661.13795829125221129132.stgit@djiang5-desk3.ch.intel.com (mailing list archive)
State Accepted
Commit 81f5eb2b11ba748ee7e393e2faf32af773ae332d
Headers show
Series dmaengine: idxd: remove trailing white space on input str for wq name | expand

Commit Message

Dave Jiang March 21, 2022, 8:40 p.m. UTC 
Add string processing with strim() in order to remove trailing white spaces
that may be input by user for the wq->name.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/idxd/sysfs.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comments

Vinod Koul April 11, 2022, 1:52 p.m. UTC | #1 
On 21-03-22, 13:40, Dave Jiang wrote:
> Add string processing with strim() in order to remove trailing white spaces
> that may be input by user for the wq->name.

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
index dbc7f9af11d3..08ceee801e4b 100644
--- a/drivers/dma/idxd/sysfs.c
+++ b/drivers/dma/idxd/sysfs.c
@@ -832,6 +832,7 @@  static ssize_t wq_name_store(struct device *dev,
 			     size_t count)
 {
 	struct idxd_wq *wq = confdev_to_wq(dev);
+	char *input, *pos;
 
 	if (wq->state != IDXD_WQ_DISABLED)
 		return -EPERM;
@@ -846,9 +847,14 @@  static ssize_t wq_name_store(struct device *dev,
 	if (wq->type == IDXD_WQT_KERNEL && device_pasid_enabled(wq->idxd))
 		return -EOPNOTSUPP;
 
+	input = kstrndup(buf, count, GFP_KERNEL);
+	if (!input)
+		return -ENOMEM;
+
+	pos = strim(input);
 	memset(wq->name, 0, WQ_NAME_SIZE + 1);
-	strncpy(wq->name, buf, WQ_NAME_SIZE);
-	strreplace(wq->name, '\n', '\0');
+	sprintf(wq->name, "%s", pos);
+	kfree(input);
 	return count;
 }