diff mbox series

dmaengine: idxd: skip clearing device context when device is read-only

Message ID 164971479479.2200566.13980022473526292759.stgit@djiang5-desk3.ch.intel.com (mailing list archive)
State Accepted
Commit 1cd8e751d96c43ece3f6842ac2244a37d9332c3a
Headers show
Series dmaengine: idxd: skip clearing device context when device is read-only | expand

Commit Message

Dave Jiang April 11, 2022, 10:06 p.m. UTC
If the device shows up as read-only configuration, skip the clearing of the
state as the context must be preserved for device re-enable after being
disabled.

Fixes: 0dcfe41e9a4c ("dmanegine: idxd: cleanup all device related bits after disabling device")
Reported-by: Tony Zhu <tony.zhu@intel.com>
Tested-by: Tony Zhu <tony.zhu@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/idxd/device.c |    3 +++
 1 file changed, 3 insertions(+)

Comments

Vinod Koul April 20, 2022, 11:47 a.m. UTC | #1
On 11-04-22, 15:06, Dave Jiang wrote:
> If the device shows up as read-only configuration, skip the clearing of the
> state as the context must be preserved for device re-enable after being
> disabled.

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 5a0535a0f850..f652da6ab47d 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -708,6 +708,9 @@  static void idxd_device_wqs_clear_state(struct idxd_device *idxd)
 
 void idxd_device_clear_state(struct idxd_device *idxd)
 {
+	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
+		return;
+
 	idxd_groups_clear_state(idxd);
 	idxd_engines_clear_state(idxd);
 	idxd_device_wqs_clear_state(idxd);