| Message ID | 165090980906.1378449.1939401700832432886.stgit@djiang5-desk3.ch.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ba997eb9c335325da37636fb2f25b8eab5b8b7ba |
| Headers | show |
| Series | dmaengine: idxd: make idxd_wq_enable() return 0 if wq is already enabled | expand |
On 25-04-22, 11:03, Dave Jiang wrote: > When calling idxd_wq_enable() and wq is already enabled, code should return 0 > and indicate function is successful instead of return error code and fail. > This should also put idxd_wq_enable() in sync with idxd_wq_disable() where > it returns 0 if wq is already disabled. Applied, thanks
diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c index 22ad9ee383e2..93cbfd726904 100644 --- a/drivers/dma/idxd/device.c +++ b/drivers/dma/idxd/device.c @@ -184,7 +184,7 @@ int idxd_wq_enable(struct idxd_wq *wq) if (wq->state == IDXD_WQ_ENABLED) { dev_dbg(dev, "WQ %d already enabled\n", wq->id); - return -ENXIO; + return 0; } idxd_cmd_exec(idxd, IDXD_CMD_ENABLE_WQ, wq->id, &status);
When calling idxd_wq_enable() and wq is already enabled, code should return 0 and indicate function is successful instead of return error code and fail. This should also put idxd_wq_enable() in sync with idxd_wq_disable() where it returns 0 if wq is already disabled. Signed-off-by: Dave Jiang <dave.jiang@intel.com> --- drivers/dma/idxd/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)