diff mbox series

dmaengine: idxd: remove redudant idxd_wq_disable_cleanup() call

Message ID 165231365717.986350.2441351765955825964.stgit@djiang5-desk3.ch.intel.com (mailing list archive)
State Accepted
Commit 4734afb0d5ed3e56494ca6f28e51bafafef4c6aa
Headers show
Series dmaengine: idxd: remove redudant idxd_wq_disable_cleanup() call | expand

Commit Message

Dave Jiang May 12, 2022, midnight UTC
idxd_wq_device_reset_cleanup() already calls idxd_wq_disable_cleanup().
There is no need to call idxd_wq_disable_cleanup() again in
idxd_device_wqs_clear_state(). Remove redudant call from
idxd_wq_device_reset_cleanup().

Fixes: 0dcfe41e9a4c ("dmanegine: idxd: cleanup all device related bits after disabling device")
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/idxd/device.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Vinod Koul May 16, 2022, 12:49 p.m. UTC | #1
On 11-05-22, 17:00, Dave Jiang wrote:
> idxd_wq_device_reset_cleanup() already calls idxd_wq_disable_cleanup().
> There is no need to call idxd_wq_disable_cleanup() again in
> idxd_device_wqs_clear_state(). Remove redudant call from
> idxd_wq_device_reset_cleanup().

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
index 8d407d2bea4f..4617219376f7 100644
--- a/drivers/dma/idxd/device.c
+++ b/drivers/dma/idxd/device.c
@@ -395,7 +395,6 @@  static void idxd_wq_device_reset_cleanup(struct idxd_wq *wq)
 {
 	lockdep_assert_held(&wq->wq_lock);
 
-	idxd_wq_disable_cleanup(wq);
 	wq->size = 0;
 	wq->group = NULL;
 }