From patchwork Tue Sep 23 15:28:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 4958111 Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D50DDBEEA5 for ; Tue, 23 Sep 2014 15:55:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A42F62024C for ; Tue, 23 Sep 2014 15:55:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 701CA2016C for ; Tue, 23 Sep 2014 15:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbaIWPzr (ORCPT ); Tue, 23 Sep 2014 11:55:47 -0400 Received: from mga01.intel.com ([192.55.52.88]:10869 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbaIWPzq (ORCPT ); Tue, 23 Sep 2014 11:55:46 -0400 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 23 Sep 2014 08:55:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="390429985" Received: from vkoul-udesk3.iind.intel.com ([10.223.96.11]) by FMSMGA003.fm.intel.com with ESMTP; 23 Sep 2014 08:49:51 -0700 Received: from vkoul-udesk3.iind.intel.com (localhost [127.0.0.1]) by vkoul-udesk3.iind.intel.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id s8NFSBKG026592; Tue, 23 Sep 2014 20:58:11 +0530 Received: (from vkoul@localhost) by vkoul-udesk3.iind.intel.com (8.14.3/8.14.3/Submit) id s8NFS9rS026590; Tue, 23 Sep 2014 20:58:09 +0530 X-Authentication-Warning: vkoul-udesk3.iind.intel.com: vkoul set sender to vinod.koul@intel.com using -f Date: Tue, 23 Sep 2014 20:58:09 +0530 From: Vinod Koul To: Fabio Estevam Cc: dmaengine@vger.kernel.org, festevam@gmail.com Subject: Re: [PATCH] dma: imx-sdma: Fix section mismatch Message-ID: <20140923152809.GN24663@intel.com> References: <1409244278-24916-1-git-send-email-fabio.estevam@freescale.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1409244278-24916-1-git-send-email-fabio.estevam@freescale.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Aug 28, 2014 at 01:44:38PM -0300, Fabio Estevam wrote: > Remove the __init annotation from sdma_probe in order to fix the following > warning: > > WARNING: drivers/dma/built-in.o(.data+0x2f4): Section mismatch in reference from > the variable sdma_driver to the function .init.text:sdma_probe() > The variable sdma_driver references the function __init sdma_probe() > If the reference is valid then annotate the > variable with __init* or __refdata (see linux/init.h) or name the variable: > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_consol This was already fixed by Marks patch commit e34b731faa7d12d3681187968ef899747e4feb55 Author: Mark Brown Date: Wed Aug 27 11:55:53 2014 +0100 dma: imx-sdma: Remove spurious __init annotation on sdma_probe() We can't annotate probe functions as __init since binding can occur at any time, not just during kernel init. Signed-off-by: Mark Brown Acked-by: Shawn Guo Signed-off-by: Vinod Koul of_match_device(sdma_dt_ids, &pdev->dev); diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index c615e88..52ce1d2 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1448,7 +1448,7 @@ static struct dma_chan *sdma_xlate(struct of_phandle_args *dma_spec, return dma_request_channel(mask, sdma_filter_fn, &data); } -static int __init sdma_probe(struct platform_device *pdev) +static int sdma_probe(struct platform_device *pdev) { const struct of_device_id *of_id =