diff mbox

dmaengine: rcar-dmac: fix platform_no_drv_owner.cocci warnings

Message ID 20141218041556.GA85607@athens (mailing list archive)
State Not Applicable
Headers show

Commit Message

Fengguang Wu Dec. 18, 2014, 4:15 a.m. UTC
drivers/dma/sh/rcar-dmac.c:1490:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 rcar-dmac.c |    1 -
 1 file changed, 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Vinod Koul Dec. 22, 2014, 3:11 p.m. UTC | #1
On Thu, Dec 18, 2014 at 12:15:56PM +0800, kbuild test robot wrote:
> drivers/dma/sh/rcar-dmac.c:1490:3-8: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Laurent,

I am assuming you will apply/fold this one?
Laurent Pinchart Dec. 23, 2014, 8:49 a.m. UTC | #2
Hi Vinod,

On Monday 22 December 2014 20:41:16 Vinod Koul wrote:
> On Thu, Dec 18, 2014 at 12:15:56PM +0800, kbuild test robot wrote:
> > drivers/dma/sh/rcar-dmac.c:1490:3-8: No need to set .owner here. The core
> > will do it.
> >
> > Remove .owner field if calls are used which set it automatically
> > 
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Laurent,
> 
> I am assuming you will apply/fold this one?

Done already.

> > ---
> > 
> >  rcar-dmac.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > --- a/drivers/dma/sh/rcar-dmac.c
> > +++ b/drivers/dma/sh/rcar-dmac.c
> > @@ -1487,7 +1487,6 @@ MODULE_DEVICE_TABLE(of, rcar_dmac_of_ids
> > 
> >  static struct platform_driver rcar_dmac_driver = {
> >  	.driver		= {
> > -		.owner	= THIS_MODULE,
> >  		.pm	= &rcar_dmac_pm,
> >  		.name	= "rcar-dmac",
> >  		.of_match_table = rcar_dmac_of_ids,
diff mbox

Patch

--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -1487,7 +1487,6 @@  MODULE_DEVICE_TABLE(of, rcar_dmac_of_ids
 
 static struct platform_driver rcar_dmac_driver = {
 	.driver		= {
-		.owner	= THIS_MODULE,
 		.pm	= &rcar_dmac_pm,
 		.name	= "rcar-dmac",
 		.of_match_table = rcar_dmac_of_ids,