| Message ID | 20161010120839.905144-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, Oct 10, 2016 at 02:07:35PM +0200, Arnd Bergmann wrote: > build testing on x86 revealed a missing dependency that leads to a link error: > > drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic': > mmp_tdma.c:(.text+0x9564): undefined reference to `gen_pool_dma_alloc' > drivers/dma/built-in.o: In function `mmp_tdma_free_chan_resources': > mmp_tdma.c:(.text+0x9675): undefined reference to `gen_pool_free' > drivers/dma/built-in.o: In function `mmp_tdma_probe': > mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get' > > This adds a 'select' statement to the driver to get it to build cleanly. Hi Arnd, I have already applied same change from Jérémy. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/dma/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index af63a6bcf564..d882eb0fa551 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -305,6 +305,7 @@ config MMP_TDMA > bool "MMP Two-Channel DMA support" > depends on ARCH_MMP || COMPILE_TEST > select DMA_ENGINE > + select GENERIC_ALLOCATOR > select MMP_SRAM if ARCH_MMP > help > Support the MMP Two-Channel DMA engine. > -- > 2.9.0 >
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index af63a6bcf564..d882eb0fa551 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -305,6 +305,7 @@ config MMP_TDMA bool "MMP Two-Channel DMA support" depends on ARCH_MMP || COMPILE_TEST select DMA_ENGINE + select GENERIC_ALLOCATOR select MMP_SRAM if ARCH_MMP help Support the MMP Two-Channel DMA engine.
build testing on x86 revealed a missing dependency that leads to a link error: drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic': mmp_tdma.c:(.text+0x9564): undefined reference to `gen_pool_dma_alloc' drivers/dma/built-in.o: In function `mmp_tdma_free_chan_resources': mmp_tdma.c:(.text+0x9675): undefined reference to `gen_pool_free' drivers/dma/built-in.o: In function `mmp_tdma_probe': mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get' This adds a 'select' statement to the driver to get it to build cleanly. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/dma/Kconfig | 1 + 1 file changed, 1 insertion(+)