From patchwork Tue Nov 8 13:48:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9417463 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 122F360459 for ; Tue, 8 Nov 2016 13:49:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0165B28A36 for ; Tue, 8 Nov 2016 13:49:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E86DB28A6D; Tue, 8 Nov 2016 13:49:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 718ED28A36 for ; Tue, 8 Nov 2016 13:49:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751099AbcKHNtw (ORCPT ); Tue, 8 Nov 2016 08:49:52 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:62504 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbcKHNtw (ORCPT ); Tue, 8 Nov 2016 08:49:52 -0500 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue102) with ESMTPA (Nemesis) id 0MBke7-1bwi7H0n5j-00AjxI; Tue, 08 Nov 2016 14:49:40 +0100 From: Arnd Bergmann To: Vinod Koul Cc: Arnd Bergmann , Dan Williams , Sinan Kaya , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dmaengine: qcom_hidma: hide MSI handler when unused Date: Tue, 8 Nov 2016 14:48:59 +0100 Message-Id: <20161108134937.1966206-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:qBKXDW2fIcjnC4FSWbBsBFRHUkJHzo9Kd8gwDAgVEBJzeV+Aslz SSi+hzbobHwL1dXZ6sPCvuhHgxyqG/EvnOWBPjBqVFrPaqxIF2kJE2kDVVsnTMMYfRV7Oo8 kfWYwx8ROScy3u6qEH34Rzpd/EMP2id3kwrNW3emNyqC3oc622SARRDnuyrZCiA4vqiVdcy +hjPQr4lSxwNKKcRjASXQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:lg9N0mlEl7s=:V+BwCxYGrQSapb65oRi/p8 QL7LMGQqqp6/FqGsX/OdwnKeiWMS6XMHsL/GWgz2zKh6yHjfMjRu1GX/zBK1NptiGQ0RMnp4i Wp5hjA3qiOe1H4C2CHJCzwyH/AHU0iowMuL7dha9b5HfLiVMSrqXQhMyw6AJMNAgIOYDaCgQJ PIVaPoPUQF+PvrfrXfMxDSbtnRQqrdHvyyvO//sbFrYByu4WtHZo5epsJxoqxFfasrWmT+0zo yIlrJmHsyFZu/vNc0cR6JOqlaUHZ+fBXGoSnhBAbhJItoGG3gB6X0A4G0snuq7962y/WHIKC9 emoMw7jKKMD/Z8dFeYLGpPYk69wIGFgwuPfgi6rTJHfY5tIX4rfOZ14JJLCEZa4yo6ztgyeI0 kLDq8aML3EsIP74/88sSQWUDO4z4FvLU3DFMV03ET5pMOTTHncWtNYM4ss8FHKs6bjm/x/TCP mKWKzpuQz45JXo5owewGbQLoh1KyqHN8svywYkm7KtSS+UDb4Rpvo2yRAdC4mdMHgnK0aNTEb +FqXz3IhMcqjLLeY/Y55dYdtWRs9yajyS4nPnuqKp3gKGMfszWUbHq1DVGqtY4YGNBweNZ3+V zPCJIpkxbtO+ygeYvJkgzrUSKsTjtquiotimBBl5xKQ9xx8VLk5BHax5qf390VuORHTc5G6xR CJ2gzy2IHXS8aQN/ZKNemZeGgOCyrGJQVPshdGR5az0tq4dFPBW6g1UYDsAKEWgaDIsU= Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The newly added MSI support causes a harmless warning when MSI is disabled: drivers/dma/qcom/hidma.c:558:20: error: 'hidma_chirq_handler_msi' defined but not used [-Werror=unused-function] This adds another #ifdef to match that around the users of the function. Fixes: 1c0e3e82a7fb ("dmaengine: qcom_hidma: add MSI support for interrupts") Signed-off-by: Arnd Bergmann Acked-by: Sinan Kaya --- drivers/dma/qcom/hidma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index d5e7991ad737..10425e134e06 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -555,6 +555,7 @@ static irqreturn_t hidma_chirq_handler(int chirq, void *arg) return hidma_ll_inthandler(chirq, lldev); } +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg) { struct hidma_lldev **lldevp = arg; @@ -563,6 +564,7 @@ static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg) return hidma_ll_inthandler_msi(chirq, *lldevp, 1 << (chirq - dmadev->msi_virqbase)); } +#endif static ssize_t hidma_show_values(struct device *dev, struct device_attribute *attr, char *buf)