diff mbox

dmaengine: pl330: Mark expected switch fall-through

Message ID 20180709114531.5116-1-vkoul@kernel.org (mailing list archive)
State Accepted
Headers show

Commit Message

Vinod Koul July 9, 2018, 11:45 a.m. UTC 
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/pl330.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski July 9, 2018, 12:37 p.m. UTC | #1 
On 9 July 2018 at 13:45, Vinod Koul <vkoul@kernel.org> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  drivers/dma/pl330.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index defcdde4d358..04fc4d8da0e9 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -1046,13 +1046,16 @@ static bool _start(struct pl330_thread *thrd)
>
>                 if (_state(thrd) == PL330_STATE_KILLING)
>                         UNTIL(thrd, PL330_STATE_STOPPED)
> +               /* fall through */
>
>         case PL330_STATE_FAULTING:
>                 _stop(thrd);
> +               /* fall through */
>
>         case PL330_STATE_KILLING:
>         case PL330_STATE_COMPLETING:
>                 UNTIL(thrd, PL330_STATE_STOPPED)
> +               /* fall through */
>
>         case PL330_STATE_STOPPED:
>                 return _trigger(thrd);

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index defcdde4d358..04fc4d8da0e9 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -1046,13 +1046,16 @@  static bool _start(struct pl330_thread *thrd)
 
 		if (_state(thrd) == PL330_STATE_KILLING)
 			UNTIL(thrd, PL330_STATE_STOPPED)
+		/* fall through */
 
 	case PL330_STATE_FAULTING:
 		_stop(thrd);
+		/* fall through */
 
 	case PL330_STATE_KILLING:
 	case PL330_STATE_COMPLETING:
 		UNTIL(thrd, PL330_STATE_STOPPED)
+		/* fall through */
 
 	case PL330_STATE_STOPPED:
 		return _trigger(thrd);