| Message ID | 20180913184724.13495-1-angelo@sysam.it (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [-next] dmaengine: mcf-edma: fix x86_64 allmodconfig compilation warning | expand |
On 13-09-18, 20:47, Angelo Dureghello wrote: > This patch fixes the compilation warning reported > during x86_64 allmodconfig build. > Please do add credit to Stephan for reporting by using Reported-By tag > Signed-off-by: Angelo Dureghello <angelo@sysam.it> > --- > drivers/dma/mcf-edma.c | 3 ++- > include/linux/platform_data/dma-mcf-edma.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/mcf-edma.c b/drivers/dma/mcf-edma.c > index 4d30d5302649..e08e2409a102 100644 > --- a/drivers/dma/mcf-edma.c > +++ b/drivers/dma/mcf-edma.c > @@ -292,8 +292,9 @@ bool mcf_edma_filter_fn(struct dma_chan *chan, void *param) > { > if (chan->device->dev->driver == &mcf_edma_driver.driver) { > struct fsl_edma_chan *mcf_chan = to_fsl_edma_chan(chan); > + unsigned int req = *(unsigned int *)param; > > - return (mcf_chan->slave_id == (u32)param); > + return (mcf_chan->slave_id == req); > } > > return false; > diff --git a/include/linux/platform_data/dma-mcf-edma.h b/include/linux/platform_data/dma-mcf-edma.h > index d718ccfa3421..97cb79bda646 100644 > --- a/include/linux/platform_data/dma-mcf-edma.h > +++ b/include/linux/platform_data/dma-mcf-edma.h > @@ -21,7 +21,7 @@ struct dma_slave_map; > > bool mcf_edma_filter_fn(struct dma_chan *chan, void *param); > > -#define MCF_EDMA_FILTER_PARAM(ch) ((void *)ch) > +#define MCF_EDMA_FILTER_PARAM(ch) ((int[]) { (ch) }) Why this change
diff --git a/drivers/dma/mcf-edma.c b/drivers/dma/mcf-edma.c index 4d30d5302649..e08e2409a102 100644 --- a/drivers/dma/mcf-edma.c +++ b/drivers/dma/mcf-edma.c @@ -292,8 +292,9 @@ bool mcf_edma_filter_fn(struct dma_chan *chan, void *param) { if (chan->device->dev->driver == &mcf_edma_driver.driver) { struct fsl_edma_chan *mcf_chan = to_fsl_edma_chan(chan); + unsigned int req = *(unsigned int *)param; - return (mcf_chan->slave_id == (u32)param); + return (mcf_chan->slave_id == req); } return false; diff --git a/include/linux/platform_data/dma-mcf-edma.h b/include/linux/platform_data/dma-mcf-edma.h index d718ccfa3421..97cb79bda646 100644 --- a/include/linux/platform_data/dma-mcf-edma.h +++ b/include/linux/platform_data/dma-mcf-edma.h @@ -21,7 +21,7 @@ struct dma_slave_map; bool mcf_edma_filter_fn(struct dma_chan *chan, void *param); -#define MCF_EDMA_FILTER_PARAM(ch) ((void *)ch) +#define MCF_EDMA_FILTER_PARAM(ch) ((int[]) { (ch) }) /** * struct mcf_edma_platform_data - platform specific data for eDMA engine
This patch fixes the compilation warning reported during x86_64 allmodconfig build. Signed-off-by: Angelo Dureghello <angelo@sysam.it> --- drivers/dma/mcf-edma.c | 3 ++- include/linux/platform_data/dma-mcf-edma.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)