From patchwork Thu Jan 23 23:03:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 11349275 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 59A18921 for ; Thu, 23 Jan 2020 23:10:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32E7E2071E for ; Thu, 23 Jan 2020 23:10:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fNhkObiS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729782AbgAWXKr (ORCPT ); Thu, 23 Jan 2020 18:10:47 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45333 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729505AbgAWXKq (ORCPT ); Thu, 23 Jan 2020 18:10:46 -0500 Received: by mail-wr1-f67.google.com with SMTP id j42so5147367wrj.12; Thu, 23 Jan 2020 15:10:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v3aEWiKiUIKlnyGDWrJTtogZVkNTJgIo6DWcgGLcpCo=; b=fNhkObiSjJhnzK5SIwdLnHYXfNxS+e+5gd4Jp12j/u4Q6WPoAX/s1EBaCABGIoeDTG xaJD/AUJ7VARy/nUlYVTmE1VbJKY9M3GfOMrgQ3abqPohuQHqFYEd1eEmHHzvy2i2uAb tRD1yGEe/d+w2oEg5EsWjZqhCq6KLgKvo7TrA/iJtIJHwm5erUcz+WGwUDc9fzPJ7Lop zwsEJNfWs6Xobe60qBwk3nJuHjHv4hZ3LebJutyJ5PgJr50dY0+e1U6AFLt2Vv1KcPhB lMJ8g/l6k3WB8O3EG0IhC9y3zxv3QxVw8oFAb02HQtWhV1x6akLV89Bbwm/3uDQ6Y5rI Q5zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v3aEWiKiUIKlnyGDWrJTtogZVkNTJgIo6DWcgGLcpCo=; b=FBvtxh6oYxRJ9qmrugrQXddpnu5TCQI9f+Vs140vOhjA/Gw84CZpSBszv6mbJdHCFi 1Z16uH4YmNt2PEtudW2m+qszYy7EeKvbU8I+o+sfppmFO3dKP1sOlfIdVhkcY8l3Uhq6 ag9mkKRE5G+TXHXktXwXVAyaduD+/WwRlhoEDpQ1idnMch8trrJu+RmBsB8tnayrkrKv HhkAEQZ7aUnGvnyGNc2H14eSkHeEhcwzb1AuMlqYa0rVKZW86eXhVVZgCV369xnX1aJs pzv3VkUaLB6zYyEA6E9PWGgTD+AF5Qic9M3dBQ1SfHDCwiML5m+wR5my/Z8rNpEG3Wqe ZkbQ== X-Gm-Message-State: APjAAAXnwk51qwAL8aaRKXCSbfzoK5aqrDZoWSm04le9LdsiSxHL7urK JXNhUjBmOTKTjsaNbN1aO9s= X-Google-Smtp-Source: APXvYqz+62yqIUxusIadJGkOBozJ4OlPot3yyml+aaBeZ0EEj/V9RTEJVTnYhkfMhC5kRIaUEtIADA== X-Received: by 2002:adf:eb8e:: with SMTP id t14mr447622wrn.384.1579821044601; Thu, 23 Jan 2020 15:10:44 -0800 (PST) Received: from localhost.localdomain (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.gmail.com with ESMTPSA id z6sm5105552wrw.36.2020.01.23.15.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2020 15:10:44 -0800 (PST) From: Dmitry Osipenko To: Laxman Dewangan , Vinod Koul , Dan Williams , Thierry Reding , Jonathan Hunter , =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 01/14] dmaengine: tegra-apb: Fix use-after-free Date: Fri, 24 Jan 2020 02:03:12 +0300 Message-Id: <20200123230325.3037-2-digetx@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20200123230325.3037-1-digetx@gmail.com> References: <20200123230325.3037-1-digetx@gmail.com> MIME-Version: 1.0 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org I was doing some experiments with I2C and noticed that Tegra APB DMA driver crashes sometime after I2C DMA transfer termination. The crash happens because tegra_dma_terminate_all() bails out immediately if pending list is empty, thus it doesn't release the half-completed descriptors which are getting re-used before ISR tasklet kicks-in. tegra-i2c 7000c400.i2c: DMA transfer timeout elants_i2c 0-0010: elants_i2c_irq: failed to read data: -110 ------------[ cut here ]------------ WARNING: CPU: 0 PID: 142 at lib/list_debug.c:45 __list_del_entry_valid+0x45/0xac list_del corruption, ddbaac44->next is LIST_POISON1 (00000100) Modules linked in: CPU: 0 PID: 142 Comm: kworker/0:2 Not tainted 5.5.0-rc2-next-20191220-00175-gc3605715758d-dirty #538 Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) Workqueue: events_freezable_power_ thermal_zone_device_check [] (unwind_backtrace) from [] (show_stack+0x11/0x14) [] (show_stack) from [] (dump_stack+0x85/0x94) [] (dump_stack) from [] (__warn+0xc1/0xc4) [] (__warn) from [] (warn_slowpath_fmt+0x61/0x78) [] (warn_slowpath_fmt) from [] (__list_del_entry_valid+0x45/0xac) [] (__list_del_entry_valid) from [] (tegra_dma_tasklet+0x5b/0x154) [] (tegra_dma_tasklet) from [] (tasklet_action_common.constprop.0+0x41/0x7c) [] (tasklet_action_common.constprop.0) from [] (__do_softirq+0xd3/0x2a8) [] (__do_softirq) from [] (irq_exit+0x7b/0x98) [] (irq_exit) from [] (__handle_domain_irq+0x45/0x80) [] (__handle_domain_irq) from [] (gic_handle_irq+0x45/0x7c) [] (gic_handle_irq) from [] (__irq_svc+0x65/0x94) Exception stack(0xde2ebb90 to 0xde2ebbd8) Cc: Signed-off-by: Dmitry Osipenko Acked-by: Jon Hunter --- drivers/dma/tegra20-apb-dma.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 3a45079d11ec..319f31d27014 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -756,10 +756,6 @@ static int tegra_dma_terminate_all(struct dma_chan *dc) bool was_busy; spin_lock_irqsave(&tdc->lock, flags); - if (list_empty(&tdc->pending_sg_req)) { - spin_unlock_irqrestore(&tdc->lock, flags); - return 0; - } if (!tdc->busy) goto skip_dma_stop;