| Message ID | 20200323171928.424223-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dmaengine: uniphier-xdmac: Remove redandant error log for platform_get_irq | expand |
On 23-03-20, 22:49, Vinod Koul wrote: > platform_get_irq prints the error on failure, so there is no need to > have caller add a log. > Remove the log in uniphier_xdmac_probe() for platform_get_irq() failure Applied, thanks
diff --git a/drivers/dma/uniphier-xdmac.c b/drivers/dma/uniphier-xdmac.c index 2f6fd518d180..7b2f8a8c2d31 100644 --- a/drivers/dma/uniphier-xdmac.c +++ b/drivers/dma/uniphier-xdmac.c @@ -525,10 +525,8 @@ static int uniphier_xdmac_probe(struct platform_device *pdev) uniphier_xdmac_chan_init(xdev, i); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "Failed to get IRQ\n"); + if (irq < 0) return irq; - } ret = devm_request_irq(dev, irq, uniphier_xdmac_irq_handler, IRQF_SHARED, "xdmac", xdev);
platform_get_irq prints the error on failure, so there is no need to have caller add a log. Remove the log in uniphier_xdmac_probe() for platform_get_irq() failure Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/dma/uniphier-xdmac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)