| Message ID | 20210214034319.11569-1-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: xilinx: dpdma: Fix compilation when !HAS_IOMEM | expand |
On 2/14/21 4:43 AM, Laurent Pinchart wrote: > The xilinx-dpdma driver uses the devm_platform_ioremap_resource() API, > which is only available when HAS_IOMEM is selected. Depend on the > Kconfig symbol to fix the error. > > While at it, also depend on ARCH_ZYNQ to avoid cluttering the > configuration on other platforms, unless COMPILE_TEST is selected. The > former would be enough to guarantee HAS_IOMEM, but with COMPILE_TEST we > still need to explicit dependendy on HAS_IOMEM. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/dma/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index d242c7632621..205bc888d49f 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -702,6 +702,8 @@ config XILINX_ZYNQMP_DMA > > config XILINX_ZYNQMP_DPDMA > tristate "Xilinx DPDMA Engine" > + depends on ARCH_ZYNQ || COMPILE_TEST Zynq doesn't have DP. ARCH_ZYNQMP here? M
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index d242c7632621..205bc888d49f 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -702,6 +702,8 @@ config XILINX_ZYNQMP_DMA config XILINX_ZYNQMP_DPDMA tristate "Xilinx DPDMA Engine" + depends on ARCH_ZYNQ || COMPILE_TEST + depends on HAS_IOMEM select DMA_ENGINE select DMA_VIRTUAL_CHANNELS help
The xilinx-dpdma driver uses the devm_platform_ioremap_resource() API, which is only available when HAS_IOMEM is selected. Depend on the Kconfig symbol to fix the error. While at it, also depend on ARCH_ZYNQ to avoid cluttering the configuration on other platforms, unless COMPILE_TEST is selected. The former would be enough to guarantee HAS_IOMEM, but with COMPILE_TEST we still need to explicit dependendy on HAS_IOMEM. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/dma/Kconfig | 2 ++ 1 file changed, 2 insertions(+)