| Message ID | 20210802184355.49879-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1,1/3] dmaengine: dw: Remove error message from DT parsing code | expand |
Hello Andy On Mon, Aug 02, 2021 at 09:43:53PM +0300, Andy Shevchenko wrote: > Users are a bit frightened of the harmless message that tells that > DT is missed on ACPI-based platforms. Remove it for good, it will > simplify the future conversion to fwnode and device property APIs. Thanks for the cleanup patchset. No comments from me, just the tags for the whole series: Reviewed-by: Serge Semin <fancer.lancer@gmail.com> Tested-by: Serge Semin <fancer.lancer@gmail.com> [Tested on Baikal-T1 DW DMAC with 8 channels, 12 requests, 2 masters, no multi-block support and uneven max burst length setup] -Sergey > > Fixes: a9ddb575d6d6 ("dmaengine: dw_dmac: Enhance device tree support") > Depends-on: f5e84eae7956 ("dmaengine: dw: platform: Split OF helpers to separate module") > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199379 > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/dma/dw/of.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/dma/dw/of.c b/drivers/dma/dw/of.c > index c1cf7675b9d1..4d2b89142721 100644 > --- a/drivers/dma/dw/of.c > +++ b/drivers/dma/dw/of.c > @@ -54,11 +54,6 @@ struct dw_dma_platform_data *dw_dma_parse_dt(struct platform_device *pdev) > u32 nr_masters; > u32 nr_channels; > > - if (!np) { > - dev_err(&pdev->dev, "Missing DT data\n"); > - return NULL; > - } > - > if (of_property_read_u32(np, "dma-masters", &nr_masters)) > return NULL; > if (nr_masters < 1 || nr_masters > DW_DMA_MAX_NR_MASTERS) > -- > 2.30.2 >
On Wed, Aug 4, 2021 at 1:50 PM Serge Semin <fancer.lancer@gmail.com> wrote: > On Mon, Aug 02, 2021 at 09:43:53PM +0300, Andy Shevchenko wrote: > > Users are a bit frightened of the harmless message that tells that > > DT is missed on ACPI-based platforms. Remove it for good, it will > > simplify the future conversion to fwnode and device property APIs. > > Thanks for the cleanup patchset. No comments from me, just the tags > for the whole series: > Reviewed-by: Serge Semin <fancer.lancer@gmail.com> > Tested-by: Serge Semin <fancer.lancer@gmail.com> > [Tested on Baikal-T1 DW DMAC with 8 channels, 12 requests, 2 masters, > no multi-block support and uneven max burst length setup] Thank you, appreciate it!
On 02-08-21, 21:43, Andy Shevchenko wrote: > Users are a bit frightened of the harmless message that tells that > DT is missed on ACPI-based platforms. Remove it for good, it will > simplify the future conversion to fwnode and device property APIs. Applied all, thanks
diff --git a/drivers/dma/dw/of.c b/drivers/dma/dw/of.c index c1cf7675b9d1..4d2b89142721 100644 --- a/drivers/dma/dw/of.c +++ b/drivers/dma/dw/of.c @@ -54,11 +54,6 @@ struct dw_dma_platform_data *dw_dma_parse_dt(struct platform_device *pdev) u32 nr_masters; u32 nr_channels; - if (!np) { - dev_err(&pdev->dev, "Missing DT data\n"); - return NULL; - } - if (of_property_read_u32(np, "dma-masters", &nr_masters)) return NULL; if (nr_masters < 1 || nr_masters > DW_DMA_MAX_NR_MASTERS)
Users are a bit frightened of the harmless message that tells that DT is missed on ACPI-based platforms. Remove it for good, it will simplify the future conversion to fwnode and device property APIs. Fixes: a9ddb575d6d6 ("dmaengine: dw_dmac: Enhance device tree support") Depends-on: f5e84eae7956 ("dmaengine: dw: platform: Split OF helpers to separate module") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199379 Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/dma/dw/of.c | 5 ----- 1 file changed, 5 deletions(-)