| Message ID | 20221111012715.2031481-1-fenghua.yu@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dc901d98b1fe6e52ab81cd3e0879379168e06daa |
| Headers | show |
| Series | dmaengine: idxd: Fix crc_val field for completion record | expand |
On 11/10/2022 5:27 PM, Fenghua Yu wrote: > The crc_val in the completion record should be 64 bits and not 32 bits. > > Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record") > > Reported-by: Nirav N Shah <nirav.n.shah@intel.com> > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > include/uapi/linux/idxd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h > index 61ee43823622..09947ae61663 100644 > --- a/include/uapi/linux/idxd.h > +++ b/include/uapi/linux/idxd.h > @@ -329,7 +329,7 @@ struct dsa_completion_record { > }; > > uint32_t delta_rec_size; > - uint32_t crc_val; > + uint64_t crc_val; > > /* DIF check & strip */ > struct {
On 10-11-22, 17:27, Fenghua Yu wrote: > The crc_val in the completion record should be 64 bits and not 32 bits. > > Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record") > Please no empty line after the fixes tag! Applied after removing the empty line, thanks > Reported-by: Nirav N Shah <nirav.n.shah@intel.com> > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> > --- > include/uapi/linux/idxd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h > index 61ee43823622..09947ae61663 100644 > --- a/include/uapi/linux/idxd.h > +++ b/include/uapi/linux/idxd.h > @@ -329,7 +329,7 @@ struct dsa_completion_record { > }; > > uint32_t delta_rec_size; > - uint32_t crc_val; > + uint64_t crc_val; > > /* DIF check & strip */ > struct { > -- > 2.32.0
diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h index 61ee43823622..09947ae61663 100644 --- a/include/uapi/linux/idxd.h +++ b/include/uapi/linux/idxd.h @@ -329,7 +329,7 @@ struct dsa_completion_record { }; uint32_t delta_rec_size; - uint32_t crc_val; + uint64_t crc_val; /* DIF check & strip */ struct {
The crc_val in the completion record should be 64 bits and not 32 bits. Fixes: 4ac823e9cd85 ("dmaengine: idxd: fix delta_rec and crc size field for completion record") Reported-by: Nirav N Shah <nirav.n.shah@intel.com> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> --- include/uapi/linux/idxd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)