diff mbox series

[v2] dmaengine: ste_dma40: use proper format string for resource_size_t

Message ID 20230519093447.4097040-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 41be14c71bae05c8daa3de5ae7fd7c2a7bc0d057
Headers show
Series [v2] dmaengine: ste_dma40: use proper format string for resource_size_t | expand

Commit Message

Arnd Bergmann May 19, 2023, 9:34 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

A fixup for a printk format string warning causes an out-of-bounds
variable access as the %pR string expects a struct resource instead of
a plain resource_size_t.

Change both to the special %pap and %pap helpers for these types.

Fixes: 5a1a3b9c19dd ("dmaengine: ste_dma40: Get LCPA SRAM from SRAM node")
Fixes: ef1e1c41a11d ("dmaengine: ste_dma40: use correct print specfier for resource_size_t")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: fix up incorrect fix misusing %pR
---
 drivers/dma/ste_dma40.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Vinod Koul May 19, 2023, 10:47 a.m. UTC | #1 
On 19-05-23, 11:34, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A fixup for a printk format string warning causes an out-of-bounds
> variable access as the %pR string expects a struct resource instead of
> a plain resource_size_t.
> 
> Change both to the special %pap and %pap helpers for these types.

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 8e9c02f83fc7..803c65cd6712 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3536,8 +3536,8 @@  static int __init d40_probe(struct platform_device *pdev)
 	}
 	base->lcpa_size = resource_size(&res_lcpa);
 	base->phy_lcpa = res_lcpa.start;
-	dev_info(dev, "found LCPA SRAM at 0x%08x, size %pR\n",
-		 (u32)base->phy_lcpa, &base->lcpa_size);
+	dev_info(dev, "found LCPA SRAM at %pad, size %pa\n",
+		 &base->phy_lcpa, &base->lcpa_size);
 
 	/* We make use of ESRAM memory for this. */
 	val = readl(base->virtbase + D40_DREG_LCPA);