| Message ID | 20231124150923.257687-3-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: xilinx: Better cyclic transfers | expand |
diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c index 75533e787414..caddd741a79c 100644 --- a/drivers/dma/xilinx/xdma.c +++ b/drivers/dma/xilinx/xdma.c @@ -745,7 +745,6 @@ static irqreturn_t xdma_channel_isr(int irq, void *dev_id) if (!vd) goto out; - xchan->busy = false; desc = to_xdma_desc(vd); xdev = xchan->xdev_hdl; @@ -768,6 +767,8 @@ static irqreturn_t xdma_channel_isr(int irq, void *dev_id) goto out; } + xchan->busy = false; + /* * if all data blocks are transferred, remove and complete the request */
The driver internal scatter-gather logic is: - set busy to true - start transfer <irq> - set busy to false - trigger next transfer if any - set busy to true Setting busy to false in cyclic transfers does not make any sense and is conceptually wrong. In order to ease the integration of additional callbacks let's move this change to a scatter-gather-only path. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- --- drivers/dma/xilinx/xdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)