| Message ID | 20240329-sdma_upstream-v4-4-daeb3067dea7@nxp.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: fsl-sdma: Some improvement for fsl-sdma | expand |
On Fri, 29 Mar 2024 10:34:44 -0400, Frank Li wrote: > Add peripheral types ID 26 for I2C because sdma firmware (sdma-6q: v3.6, > sdma-7d: v4.6) support I2C DMA transfer. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml | 1 + > 1 file changed, 1 insertion(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed. Missing tags: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
On 29/03/2024 15:34, Frank Li wrote: > Add peripheral types ID 26 for I2C because sdma firmware (sdma-6q: v3.6, > sdma-7d: v4.6) support I2C DMA transfer. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
On 29-03-24, 10:34, Frank Li wrote: > Add peripheral types ID 26 for I2C because sdma firmware (sdma-6q: v3.6, > sdma-7d: v4.6) support I2C DMA transfer. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > index b95dd8db5a30a..80bcd3a6ecaf3 100644 > --- a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > +++ b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > @@ -93,6 +93,7 @@ properties: > - Shared ASRC: 23 > - SAI: 24 > - HDMI Audio: 25 > + - I2C: 26 Sorry comment was for this patch, I have skipped these two now > > The third cell: transfer priority ID > enum: > > -- > 2.34.1
diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml index b95dd8db5a30a..80bcd3a6ecaf3 100644 --- a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml +++ b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml @@ -93,6 +93,7 @@ properties: - Shared ASRC: 23 - SAI: 24 - HDMI Audio: 25 + - I2C: 26 The third cell: transfer priority ID enum:
Add peripheral types ID 26 for I2C because sdma firmware (sdma-6q: v3.6, sdma-7d: v4.6) support I2C DMA transfer. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml | 1 + 1 file changed, 1 insertion(+)