| Message ID | 20240516102532.213874-2-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ea00def538eceda618b940fef757f55c1190e327 |
| Headers | show |
| Series | [1/2] firmware: add nowarn variant of request_firmware_nowait() | expand |
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 9b42f5e96b1e..b94aef57c2c0 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -2057,9 +2057,8 @@ static int sdma_get_firmware(struct sdma_engine *sdma, { int ret; - ret = request_firmware_nowait(THIS_MODULE, - FW_ACTION_UEVENT, fw_name, sdma->dev, - GFP_KERNEL, sdma, sdma_load_firmware); + ret = firmware_request_nowait_nowarn(THIS_MODULE, fw_name, sdma->dev, + GFP_KERNEL, sdma, sdma_load_firmware); return ret; }
The SDMA firmware is optional and a usable fallback to the internal ROM firmware is present in the driver. There is already a message printed informing the user that the internal firmware is used, so there is no need to print a scary warning for what is normal operation on most systems. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- v3: - v2-link: https://lore.kernel.org/all/20181112160143.4459-1-l.stach@pengutronix.de/ - Adapt to new firmware_* API --- drivers/dma/imx-sdma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)