| Message ID | 20240602013319.2975894-1-s-vadapalli@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ba27e9d2207784da748b19170a2e56bd7770bd81 |
| Headers | show |
| Series | [v2] dmaengine: ti: k3-udma-glue: Fix of_k3_udma_glue_parse_chn_by_id() | expand |
On Sun, 02 Jun 2024 07:03:19 +0530, Siddharth Vadapalli wrote: > The of_k3_udma_glue_parse_chn_by_id() helper function erroneously > invokes "of_node_put()" on the "udmax_np" device-node passed to it, > without having incremented its reference count at any point. Fix it. > > Applied, thanks! [1/1] dmaengine: ti: k3-udma-glue: Fix of_k3_udma_glue_parse_chn_by_id() commit: ba27e9d2207784da748b19170a2e56bd7770bd81 Best regards,
diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c index c9b93055dc9d..f0a399cf45b2 100644 --- a/drivers/dma/ti/k3-udma-glue.c +++ b/drivers/dma/ti/k3-udma-glue.c @@ -200,12 +200,9 @@ of_k3_udma_glue_parse_chn_by_id(struct device_node *udmax_np, struct k3_udma_glu ret = of_k3_udma_glue_parse(udmax_np, common); if (ret) - goto out_put_spec; + return ret; ret = of_k3_udma_glue_parse_chn_common(common, thread_id, tx_chn); - -out_put_spec: - of_node_put(udmax_np); return ret; }
The of_k3_udma_glue_parse_chn_by_id() helper function erroneously invokes "of_node_put()" on the "udmax_np" device-node passed to it, without having incremented its reference count at any point. Fix it. Fixes: 81a1f90f20af ("dmaengine: ti: k3-udma-glue: Add function to parse channel by ID") Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> --- Hello, This patch is based on commit 83814698cf48 Merge tag 'powerpc-6.10-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux of Mainline Linux. v1 of this patch is at: https://lore.kernel.org/r/20240518100556.2551788-1-s-vadapalli@ti.com/ Changes since v1: - Rebased patch on latest Mainline Linux. - Collected "Acked-by" tag from Peter Ujfalusi <peter.ujfalusi@gmail.com> from: https://lore.kernel.org/r/8b2e4b7f-50ae-4017-adf2-2e990cd45a25@gmail.com/ - Updated commit message based on feedback from Markus Elfring <Markus.Elfring@web.de> at: https://lore.kernel.org/r/22a66571-0a0c-46dd-899a-d24079372880@web.de/ with the change being: s/..incremented its reference at../..incremented its reference count at../ Regards, Siddharth. drivers/dma/ti/k3-udma-glue.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)