| Message ID | 20240704020802.3371203-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/1] dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma | expand |
On 04/07/2024 04:08, Frank Li wrote: > The IP of QDMA ls1028/ls1043/ls1046/ is same as ls1021. So allow compatible > string fallback to fsl,ls1021a-qdma. > > The difference is that ls1021a-qdma have 3 irqs, and other have 5 irqs. > > Fix below CHECK_DTB warning. > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: dma-controller@8380000: compatible: ['fsl,ls1046a-qdma', 'fsl,ls1021a-qdma'] is too long > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 03-07-24, 22:08, Frank Li wrote: > The IP of QDMA ls1028/ls1043/ls1046/ is same as ls1021. So allow compatible > string fallback to fsl,ls1021a-qdma. > > The difference is that ls1021a-qdma have 3 irqs, and other have 5 irqs. > > Fix below CHECK_DTB warning. > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: dma-controller@8380000: compatible: ['fsl,ls1046a-qdma', 'fsl,ls1021a-qdma'] is too long This fails for me, can you please rebase
On Wed, 03 Jul 2024 22:08:02 -0400, Frank Li wrote: > The IP of QDMA ls1028/ls1043/ls1046/ is same as ls1021. So allow compatible > string fallback to fsl,ls1021a-qdma. > > The difference is that ls1021a-qdma have 3 irqs, and other have 5 irqs. > > Fix below CHECK_DTB warning. > arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: dma-controller@8380000: compatible: ['fsl,ls1046a-qdma', 'fsl,ls1021a-qdma'] is too long > > [...] Applied, thanks! [1/1] dt-bindings: fsl-qdma: allow compatible string fallback to fsl,ls1021a-qdma commit: 0204485c5a1e2de00acfd83c3931bd9dc6493c64 Best regards,
diff --git a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml index 1b689a2529c87..9401b1f6300d4 100644 --- a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml +++ b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml @@ -11,11 +11,14 @@ maintainers: properties: compatible: - enum: - - fsl,ls1021a-qdma - - fsl,ls1028a-qdma - - fsl,ls1043a-qdma - - fsl,ls1046a-qdma + oneOf: + - const: fsl,ls1021a-qdma + - items: + - enum: + - fsl,ls1028a-qdma + - fsl,ls1043a-qdma + - fsl,ls1046a-qdma + - const: fsl,ls1021a-qdma reg: items: @@ -89,8 +92,16 @@ allOf: compatible: contains: enum: - - fsl,ls1021a-qdma + - fsl,ls1028a-qdma + - fsl,ls1043a-qdma + - fsl,ls1046a-qdma then: + properties: + interrupts: + minItems: 5 + interrupt-names: + minItems: 5 + else: properties: interrupts: maxItems: 3
The IP of QDMA ls1028/ls1043/ls1046/ is same as ls1021. So allow compatible string fallback to fsl,ls1021a-qdma. The difference is that ls1021a-qdma have 3 irqs, and other have 5 irqs. Fix below CHECK_DTB warning. arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dtb: dma-controller@8380000: compatible: ['fsl,ls1046a-qdma', 'fsl,ls1021a-qdma'] is too long Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change from v2 to v3 - previous patch missed a dependent change. https://lore.kernel.org/imx/20240701195717.1843041-1-Frank.Li@nxp.com/T/#u - Combine depedent change to one patch. Change from v1 to v2 - Change maxItems: 5 to minItems: 5. because maxItems: 5 already restrict at top interrupts: minItems: 2 maxItems: 5 --- --- .../devicetree/bindings/dma/fsl-qdma.yaml | 23 ++++++++++++++----- 1 file changed, 17 insertions(+), 6 deletions(-)