| Message ID | 87ttbw3zq7.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: sh: rcar-dmac: remove r8a779a0 settings | expand |
Hi Morimoto-san, On Mon, Nov 25, 2024 at 1:48 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > Historically r8a779a0 SoC specific compatible was added to rcar-dmac, > but it is same as Gen4 today, and r8a779a0 SoC DT has both SoC and Gen4 > compatible. SoC specific compatible is no longer needed. Let's remove it. > > static const struct of_device_id rcar_dmac_of_ids[] = { > ... > }, { > .compatible = "renesas,rcar-gen4-dmac", > => .data = &rcar_gen4_dmac_data, > }, { > .compatible = "renesas,dmac-r8a779a0", > => .data = &rcar_gen4_dmac_data, > }, > > dmacX: dma-controller@XXXXX { > => compatible = "renesas,dmac-r8a779a0", > => "renesas,rcar-gen4-dmac"; > ... > }; > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Thanks for your patch! > --- a/drivers/dma/sh/rcar-dmac.c > +++ b/drivers/dma/sh/rcar-dmac.c > @@ -2022,9 +2022,6 @@ static const struct of_device_id rcar_dmac_of_ids[] = { > }, { > .compatible = "renesas,rcar-gen4-dmac", > .data = &rcar_gen4_dmac_data, > - }, { > - .compatible = "renesas,dmac-r8a779a0", > - .data = &rcar_gen4_dmac_data, > }, > { /* Sentinel */ } > }; This compatible value was retained in the driver because of DT backwards compatibility: DTBs created between v5.12 and v5.19 use only "renesas,dmac-r8a779a0". Gr{oetje,eeting}s, Geert
Hi Geert > This compatible value was retained in the driver because of DT > backwards compatibility: DTBs created between v5.12 and v5.19 use only > "renesas,dmac-r8a779a0". Ah, OK. But I want to know this info on driver. I will post v2 patch. Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c index 1094a2f821649..d50fb3f166532 100644 --- a/drivers/dma/sh/rcar-dmac.c +++ b/drivers/dma/sh/rcar-dmac.c @@ -2022,9 +2022,6 @@ static const struct of_device_id rcar_dmac_of_ids[] = { }, { .compatible = "renesas,rcar-gen4-dmac", .data = &rcar_gen4_dmac_data, - }, { - .compatible = "renesas,dmac-r8a779a0", - .data = &rcar_gen4_dmac_data, }, { /* Sentinel */ } };
Historically r8a779a0 SoC specific compatible was added to rcar-dmac, but it is same as Gen4 today, and r8a779a0 SoC DT has both SoC and Gen4 compatible. SoC specific compatible is no longer needed. Let's remove it. static const struct of_device_id rcar_dmac_of_ids[] = { ... }, { .compatible = "renesas,rcar-gen4-dmac", => .data = &rcar_gen4_dmac_data, }, { .compatible = "renesas,dmac-r8a779a0", => .data = &rcar_gen4_dmac_data, }, dmacX: dma-controller@XXXXX { => compatible = "renesas,dmac-r8a779a0", => "renesas,rcar-gen4-dmac"; ... }; Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/dma/sh/rcar-dmac.c | 3 --- 1 file changed, 3 deletions(-)