From patchwork Thu Nov 28 22:58:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 3255991 X-Patchwork-Delegate: dan.j.williams@gmail.com Return-Path: X-Original-To: patchwork-dmaengine@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AA3B5BEEAD for ; Thu, 28 Nov 2013 22:58:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3C68920624 for ; Thu, 28 Nov 2013 22:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 303BA203F3 for ; Thu, 28 Nov 2013 22:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750932Ab3K1W6z (ORCPT ); Thu, 28 Nov 2013 17:58:55 -0500 Received: from mail-bk0-f53.google.com ([209.85.214.53]:52460 "EHLO mail-bk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128Ab3K1W6z (ORCPT ); Thu, 28 Nov 2013 17:58:55 -0500 Received: by mail-bk0-f53.google.com with SMTP id na10so3978720bkb.40 for ; Thu, 28 Nov 2013 14:58:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=J1K+dCpNQirDxbOHZYF3KUbKVN2W7VQmgfgav0FbaxA=; b=D72aBdVsYnZZgvLBBeQ0xj47LDzjsf0pIIJw5OgbA/21BZrUz1f3OieHbJVphuhzTo HpV7f15Mg2zxt1bD9pP7ngSdXPnZBq89drwbD95wI94XYuNBeuWBlr8A2u+fYq6lyHgR TqKOOzkcrKQspRLw8ERE2kwsWigGZ7enkeCTn7KLqGGpEy+Rf0QEXTizgS6Aumm44GCK v6NCtU75y1getTdOQF+V0djpxtZgRjim9YkbCr8C3pvqpN/FtlG1A24YGJvrzDLx1nAz bF43vpQjGjkEbl6GoPHkmEimGpR4Vlqne+cCWa4lpJ1BbsoMKUI9SaY0OHeAKOVRh/1X xzCA== X-Gm-Message-State: ALoCoQlO8q7vztwyhtyvShFU1VNm9buR6DmWqkiah97I4mCWBCtLQimHfCEm5mWAedSVNtK4ZL06 MIME-Version: 1.0 X-Received: by 10.205.86.131 with SMTP id as3mr38551bkc.89.1385679533302; Thu, 28 Nov 2013 14:58:53 -0800 (PST) Received: by 10.205.44.200 with HTTP; Thu, 28 Nov 2013 14:58:53 -0800 (PST) Date: Thu, 28 Nov 2013 14:58:53 -0800 Message-ID: Subject: Build warning in drivers/dma/mmp_tdma.c From: Dan Williams To: Zhangfei Gao , Qiao Zhou , Leo Yan Cc: "dmaengine@vger.kernel.org" , Vinod Koul , "linux-arm-kernel@lists.infradead.org" Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP My build warning test is failing on this driver please fix: drivers/dma/mmp_tdma.c:236:8: warning: 'tdcr' may be used uninitialized in this function [-Wuninitialized] It's valid as mmp_tdma_control as the direction is specified in mmp_tdma_control() and may not be one of the two tests in that branch. I'm also carrying patch to add a missing dependency: commit 1a4ee91dacedde3e82d8ce6eeace7f16884474f9 Author: Dan Williams Date: Thu Nov 28 12:27:38 2013 -0800 dma: mmp_dma depends on CPU_MMP2 It calls sram_get_gpool() which is only defined if CONFIG_CPU_MMP2=y Signed-off-by: Dan Williams Is there a different ARCH type that this driver should be depending on? --- Dan -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 446687cc2334..dad83634cb65 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -287,7 +287,7 @@ config DMA_SA11X0 config MMP_TDMA bool "MMP Two-Channel DMA support" - depends on ARCH_MMP + depends on ARCH_MMP && CPU_MMP2 select DMA_ENGINE help Support the MMP Two-Channel DMA engine.