mbox series

[v2,0/2] UEFI v2.8 Memory Error Record Updates

Message ID 20200819143544.155096-1-alex.kluver@hpe.com (mailing list archive)
Headers show
Series UEFI v2.8 Memory Error Record Updates | expand

Message

Alex Kluver Aug. 19, 2020, 2:35 p.m. UTC
The UEFI Specification v2.8, Table 299, Memory Error Record has
several changes from previous versions. Bits 18 through 21 have been
added to the memory validation bits to include an extended version
of row, an option to print bank address and group separately, and chip id.
These patches implement bits 18 through 21 into the Memory Error Record.

Change reserved field to extended field in cper_sec_mem_err structure
and added the extended field to the cper_mem_err_compact structure.

Print correct versions of row, bank, and chip ID.
---
v1 -> v2:
   * Add static inline cper_get_mem_extension to make
     it more readable, as suggested by Borislav Petkov

   * Add second patch for bank field, bank group, and chip id.
---
Alex Kluver (2):
  edac,ghes,cper: Add Row Extension to Memory Error Record
  cper,edac,efi: Memory Error Record: bank group/address and chip id

 drivers/edac/ghes_edac.c    | 17 +++++++++++++++--
 drivers/firmware/efi/cper.c | 18 ++++++++++++++++--
 include/linux/cper.h        | 24 ++++++++++++++++++++++--
 3 files changed, 53 insertions(+), 6 deletions(-)

Comments

Russ Anderson Sept. 14, 2020, 4:44 p.m. UTC | #1
On Wed, Aug 19, 2020 at 09:35:42AM -0500, Alex Kluver wrote:
> The UEFI Specification v2.8, Table 299, Memory Error Record has
> several changes from previous versions. Bits 18 through 21 have been
> added to the memory validation bits to include an extended version
> of row, an option to print bank address and group separately, and chip id.
> These patches implement bits 18 through 21 into the Memory Error Record.
> 
> Change reserved field to extended field in cper_sec_mem_err structure
> and added the extended field to the cper_mem_err_compact structure.
> 
> Print correct versions of row, bank, and chip ID.

Are there any community comment on this patch set?
Questions/comments/concerns?

Thanks.

> ---
> v1 -> v2:
>    * Add static inline cper_get_mem_extension to make
>      it more readable, as suggested by Borislav Petkov
> 
>    * Add second patch for bank field, bank group, and chip id.
> ---
> Alex Kluver (2):
>   edac,ghes,cper: Add Row Extension to Memory Error Record
>   cper,edac,efi: Memory Error Record: bank group/address and chip id
> 
>  drivers/edac/ghes_edac.c    | 17 +++++++++++++++--
>  drivers/firmware/efi/cper.c | 18 ++++++++++++++++--
>  include/linux/cper.h        | 24 ++++++++++++++++++++++--
>  3 files changed, 53 insertions(+), 6 deletions(-)
> 
> -- 
> 2.26.2
>
Ard Biesheuvel Sept. 15, 2020, 3:07 p.m. UTC | #2
On Wed, 19 Aug 2020 at 17:36, Alex Kluver <alex.kluver@hpe.com> wrote:
>
> The UEFI Specification v2.8, Table 299, Memory Error Record has
> several changes from previous versions. Bits 18 through 21 have been
> added to the memory validation bits to include an extended version
> of row, an option to print bank address and group separately, and chip id.
> These patches implement bits 18 through 21 into the Memory Error Record.
>
> Change reserved field to extended field in cper_sec_mem_err structure
> and added the extended field to the cper_mem_err_compact structure.
>
> Print correct versions of row, bank, and chip ID.
> ---
> v1 -> v2:
>    * Add static inline cper_get_mem_extension to make
>      it more readable, as suggested by Borislav Petkov
>
>    * Add second patch for bank field, bank group, and chip id.
> ---
> Alex Kluver (2):
>   edac,ghes,cper: Add Row Extension to Memory Error Record
>   cper,edac,efi: Memory Error Record: bank group/address and chip id
>
>  drivers/edac/ghes_edac.c    | 17 +++++++++++++++--
>  drivers/firmware/efi/cper.c | 18 ++++++++++++++++--
>  include/linux/cper.h        | 24 ++++++++++++++++++++++--
>  3 files changed, 53 insertions(+), 6 deletions(-)
>

For the series,

Acked-by: Ard Biesheuvel <ardb@kernel.org>