mbox series

[v5,0/2] Two x86 fixes

Message ID 20220310015306.445359-1-ammarfaizi2@gnuweeb.org (mailing list archive)
Headers show
Series Two x86 fixes | expand

Message

Ammar Faizi March 10, 2022, 1:53 a.m. UTC
Hi,

Two x86 fixes in this series.

1) x86/delay: Fix the wrong Assembly constraint in delay_loop() function.
2) x86/MCE/AMD: Fix memory leak when `threshold_create_bank()` fails.

## Changelog

v5:
  - Mark patch #1 for stable.
  - Commit message improvement for patch #1 and #2.
  - Fold in changes from Yazen and Alviro (for patch #2).

v4:
  - Address comment from Greg, sha1 commit Fixes only needs
    to be 12 chars.
  - Add the author of the fixed commit to the CC list.

v3:
  - Fold in changes from Alviro, the previous version is still
    leaking @bank[n].

v2:
  - Fix wrong copy/paste.

Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Ammar Faizi (2):
  x86/delay: Fix the wrong asm constraint in `delay_loop()`
  x86/MCE/AMD: Fix memory leak when `threshold_create_bank()` fails

 arch/x86/kernel/cpu/mce/amd.c | 32 +++++++++++++++++++-------------
 arch/x86/lib/delay.c          |  4 ++--
 2 files changed, 21 insertions(+), 15 deletions(-)


base-commit: 7e57714cd0ad2d5bb90e50b5096a0e671dec1ef3

Comments

Ammar Faizi March 17, 2022, 8:19 a.m. UTC | #1
On Thu, Mar 10, 2022 at 8:53 AM Ammar Faizi wrote:
> Two x86 fixes in this series.
>
> 1) x86/delay: Fix the wrong Assembly constraint in delay_loop() function.
> 2) x86/MCE/AMD: Fix memory leak when `threshold_create_bank()` fails.

Ping (1)!
Borislav? Thomas?

Ref: https://lore.kernel.org/lkml/20220310015306.445359-1-ammarfaizi2@gnuweeb.org/
Borislav Petkov March 17, 2022, 9:27 a.m. UTC | #2
On Thu, Mar 17, 2022 at 03:19:07PM +0700, Ammar Faizi wrote:
> On Thu, Mar 10, 2022 at 8:53 AM Ammar Faizi wrote:
> > Two x86 fixes in this series.
> >
> > 1) x86/delay: Fix the wrong Assembly constraint in delay_loop() function.
> > 2) x86/MCE/AMD: Fix memory leak when `threshold_create_bank()` fails.
> 
> Ping (1)!
> Borislav? Thomas?

Yes, what's up?

Are those urgent fixes which break some use case or can you simply sit
patiently and wait?

Because we have an upcoming merge window and we need to prepare for
that. And there are real bugs that need fixing too.

So what's the rush here?
Ammar Faizi March 17, 2022, 9:50 a.m. UTC | #3
On Thu, Mar 17, 2022 at 4:27 PM Borislav Petkov wrote:
> Yes, what's up?
>
> Are those urgent fixes which break some use case or can you simply sit
> patiently and wait?

Sorry for pinging at the wrong time. Excuse my weekly ping. They are
not urgent fixes. So no rush.

> Because we have an upcoming merge window and we need to prepare for
> that. And there are real bugs that need fixing too.

Hopefully, the 5.17 release and 5.18 merge window go well.