[0/2] edac: Add support to handle Deferred Error

Message

Kamati Srinivas March 3, 2023, 12:54 p.m. UTC

This patchset adds support to handle Deferred error, also
cleans up the code for log_ue/ce and corresponding APIs.

Kamati Srinivas (2):
  edac: Modify sysfs enabled values log_ue, log_ce to bool
  edac: Add support to handle DE (Deferred Errors)

 drivers/edac/edac_device.c       | 57 ++++++++++++++++++++++++++++++--
 drivers/edac/edac_device.h       | 34 +++++++++++++++++--
 drivers/edac/edac_device_sysfs.c | 50 ++++++++++++++++++++++++----
 3 files changed, 130 insertions(+), 11 deletions(-)

Comments

Zhuo, Qiuxu March 4, 2023, 3:30 a.m. UTC | #1

> From: Kamati Srinivas <[e-mail]>
> ...
>
> This patchset adds support to handle Deferred error, also

  It would be better if there is a use case showing some EDAC
  driver(s) needs this newly added "Deferred Error" code
  in the EDAC core.

  -Qiuxu

> cleans up the code for log_ue/ce and corresponding APIs.
> 
> Kamati Srinivas (2):
>   edac: Modify sysfs enabled values log_ue, log_ce to bool
>   edac: Add support to handle DE (Deferred Errors)
> 
>  drivers/edac/edac_device.c       | 57 ++++++++++++++++++++++++++++++--
>  drivers/edac/edac_device.h       | 34 +++++++++++++++++--
>  drivers/edac/edac_device_sysfs.c | 50 ++++++++++++++++++++++++----
>  3 files changed, 130 insertions(+), 11 deletions(-)

Yazen Ghannam April 20, 2023, 5:49 p.m. UTC | #2

On 3/3/23 22:30, Qiuxu Zhuo wrote:
>> From: Kamati Srinivas <[e-mail]>
>> ...
>>
>> This patchset adds support to handle Deferred error, also
> 
>   It would be better if there is a use case showing some EDAC
>   driver(s) needs this newly added "Deferred Error" code
>   in the EDAC core.
>

I agree. On AMD systems, "deferred" errors are uncorrectable errors that
do not require immediate action. This may be similar to "action
optional" errors. They are still uncorrectable errors and can be counted
as such.

Thanks,
Yazen