| Message ID | 0c046ef5cfb367a3f707ef4270e21a2bcbf44952.1620280098.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC/thunderx: Fix an error message | expand |
On Thu, May 06, 2021 at 07:49:34AM +0200, Christophe JAILLET wrote: > 'ret' is known to be 0 here. > No error code is available, so just remove it from the error message. > > Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/edac/thunderx_edac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c > index 0eb5eb97fd74..f13674081cb6 100644 > --- a/drivers/edac/thunderx_edac.c > +++ b/drivers/edac/thunderx_edac.c > @@ -1368,7 +1368,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev, > name, 1, "CCPI", 1, > 0, NULL, 0, idx); > if (!edac_dev) { > - dev_err(&pdev->dev, "Cannot allocate EDAC device: %d\n", ret); > + dev_err(&pdev->dev, "Cannot allocate EDAC device\n"); > return -ENOMEM; > } > ocx = edac_dev->pvt_info; > @@ -1380,7 +1380,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev, > > ocx->regs = pcim_iomap_table(pdev)[0]; > if (!ocx->regs) { > - dev_err(&pdev->dev, "Cannot map PCI resources: %d\n", ret); > + dev_err(&pdev->dev, "Cannot map PCI resources\n"); > ret = -ENODEV; > goto err_free; > } > -- Applied, thanks.
diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c index 0eb5eb97fd74..f13674081cb6 100644 --- a/drivers/edac/thunderx_edac.c +++ b/drivers/edac/thunderx_edac.c @@ -1368,7 +1368,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev, name, 1, "CCPI", 1, 0, NULL, 0, idx); if (!edac_dev) { - dev_err(&pdev->dev, "Cannot allocate EDAC device: %d\n", ret); + dev_err(&pdev->dev, "Cannot allocate EDAC device\n"); return -ENOMEM; } ocx = edac_dev->pvt_info; @@ -1380,7 +1380,7 @@ static int thunderx_ocx_probe(struct pci_dev *pdev, ocx->regs = pcim_iomap_table(pdev)[0]; if (!ocx->regs) { - dev_err(&pdev->dev, "Cannot map PCI resources: %d\n", ret); + dev_err(&pdev->dev, "Cannot map PCI resources\n"); ret = -ENODEV; goto err_free; }
'ret' is known to be 0 here. No error code is available, so just remove it from the error message. Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/edac/thunderx_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)