| Message ID | 20200714142308.46612-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] EDAC, thunderx: Make symbol 'lmc_dfs_ents' static | expand |
On 14.07.20 22:23:08, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/edac/thunderx_edac.c:457:22: warning: > symbol 'lmc_dfs_ents' was not declared. Should it be static? > > Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so > marks it static. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Acked-by: Robert Richter <rrichter@marvell.com> > --- > drivers/edac/thunderx_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c > index 4af9744cc6d0..0eb5eb97fd74 100644 > --- a/drivers/edac/thunderx_edac.c > +++ b/drivers/edac/thunderx_edac.c > @@ -454,7 +454,7 @@ DEBUGFS_STRUCT(inject_int, 0200, thunderx_lmc_inject_int_write, NULL); > DEBUGFS_STRUCT(inject_ecc, 0200, thunderx_lmc_inject_ecc_write, NULL); > DEBUGFS_STRUCT(int_w1c, 0400, NULL, thunderx_lmc_int_read); > > -struct debugfs_entry *lmc_dfs_ents[] = { > +static struct debugfs_entry *lmc_dfs_ents[] = { > &debugfs_mask0, > &debugfs_mask2, > &debugfs_parity_test, >
On Tue, Jul 14, 2020 at 10:23:08PM +0800, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/edac/thunderx_edac.c:457:22: warning: > symbol 'lmc_dfs_ents' was not declared. Should it be static? > > Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so > marks it static. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/edac/thunderx_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c > index 4af9744cc6d0..0eb5eb97fd74 100644 > --- a/drivers/edac/thunderx_edac.c > +++ b/drivers/edac/thunderx_edac.c > @@ -454,7 +454,7 @@ DEBUGFS_STRUCT(inject_int, 0200, thunderx_lmc_inject_int_write, NULL); > DEBUGFS_STRUCT(inject_ecc, 0200, thunderx_lmc_inject_ecc_write, NULL); > DEBUGFS_STRUCT(int_w1c, 0400, NULL, thunderx_lmc_int_read); > > -struct debugfs_entry *lmc_dfs_ents[] = { > +static struct debugfs_entry *lmc_dfs_ents[] = { > &debugfs_mask0, > &debugfs_mask2, > &debugfs_parity_test, Applied, thanks.
diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c index 4af9744cc6d0..0eb5eb97fd74 100644 --- a/drivers/edac/thunderx_edac.c +++ b/drivers/edac/thunderx_edac.c @@ -454,7 +454,7 @@ DEBUGFS_STRUCT(inject_int, 0200, thunderx_lmc_inject_int_write, NULL); DEBUGFS_STRUCT(inject_ecc, 0200, thunderx_lmc_inject_ecc_write, NULL); DEBUGFS_STRUCT(int_w1c, 0400, NULL, thunderx_lmc_int_read); -struct debugfs_entry *lmc_dfs_ents[] = { +static struct debugfs_entry *lmc_dfs_ents[] = { &debugfs_mask0, &debugfs_mask2, &debugfs_parity_test,
The sparse tool complains as follows: drivers/edac/thunderx_edac.c:457:22: warning: symbol 'lmc_dfs_ents' was not declared. Should it be static? Symbol 'lmc_dfs_ents' is not used outside of thunderx_edac.c, so marks it static. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/edac/thunderx_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)