From patchwork Tue Jun 8 08:47:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ChenXiaoSong X-Patchwork-Id: 12305845 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE98AC47082 for ; Tue, 8 Jun 2021 08:41:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 949B161289 for ; Tue, 8 Jun 2021 08:41:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230525AbhFHImw (ORCPT ); Tue, 8 Jun 2021 04:42:52 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:4400 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbhFHImw (ORCPT ); Tue, 8 Jun 2021 04:42:52 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4FzkBC2YPfz6vbH; Tue, 8 Jun 2021 16:37:07 +0800 (CST) Received: from dggemi758-chm.china.huawei.com (10.1.198.144) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 8 Jun 2021 16:40:57 +0800 Received: from huawei.com (10.175.101.6) by dggemi758-chm.china.huawei.com (10.1.198.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 8 Jun 2021 16:40:57 +0800 From: ChenXiaoSong To: , , , CC: , , , , Subject: [PATCH -next,resend] EDAC/armada_xp: Remove redundant dev_err call in axp_mc_probe() and aurora_l2_probe() Date: Tue, 8 Jun 2021 16:47:15 +0800 Message-ID: <20210608084715.1046300-1-chenxiaosong2@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggemi758-chm.china.huawei.com (10.1.198.144) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: ChenXiaoSong --- drivers/edac/armada_xp_edac.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.25.4 diff --git a/drivers/edac/armada_xp_edac.c b/drivers/edac/armada_xp_edac.c index e3e757513d1b..9661c72e6554 100644 --- a/drivers/edac/armada_xp_edac.c +++ b/drivers/edac/armada_xp_edac.c @@ -297,10 +297,8 @@ static int axp_mc_probe(struct platform_device *pdev) } base = devm_ioremap_resource(&pdev->dev, r); - if (IS_ERR(base)) { - dev_err(&pdev->dev, "Unable to map regs\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } config = readl(base + SDRAM_CONFIG_REG); if (!(config & SDRAM_CONFIG_ECC_MASK)) { @@ -525,10 +523,8 @@ static int aurora_l2_probe(struct platform_device *pdev) } base = devm_ioremap_resource(&pdev->dev, r); - if (IS_ERR(base)) { - dev_err(&pdev->dev, "Unable to map regs\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } l2x0_aux_ctrl = readl(base + L2X0_AUX_CTRL); if (!(l2x0_aux_ctrl & AURORA_ACR_PARITY_EN))