| Message ID | 20210630152828.162659-2-nchatrad@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86/edac/amd64: Add support for noncpu nodes | expand |
On Wed, Jun 30, 2021 at 08:58:22PM +0530, Naveen Krishna Chatradhi wrote: > From: Muralidhara M K <muralimk@amd.com> > > Add Aldebaran device to the PCI ID database. Since this device has a > configurable PCIe endpoint, it could be used with different drivers. > > Signed-off-by: Muralidhara M K <muralimk@amd.com> > Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com> > --- > include/linux/pci_ids.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 4bac1831de80..d9aae90dfce9 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -554,6 +554,7 @@ > #define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493 > #define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b > #define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443 > +#define PCI_DEVICE_ID_AMD_ALDEBARAN_DF_F3 0x14d3 > #define PCI_DEVICE_ID_AMD_19H_DF_F3 0x1653 > #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d > #define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703 > -- The PCI ID looks right. But I think this patch can be part of the next patch where this value is first used. Thanks, Yazen
[Public] Hi Yazen -----Original Message----- From: Ghannam, Yazen <Yazen.Ghannam@amd.com> Sent: Tuesday, July 20, 2021 12:59 AM To: Chatradhi, Naveen Krishna <NaveenKrishna.Chatradhi@amd.com> Cc: linux-edac@vger.kernel.org; x86@kernel.org; linux-kernel@vger.kernel.org; bp@alien8.de; mingo@redhat.com; mchehab@kernel.org Subject: Re: [PATCH 1/7] x86/amd_nb: Add Aldebaran device to PCI IDs On Wed, Jun 30, 2021 at 08:58:22PM +0530, Naveen Krishna Chatradhi wrote: > From: Muralidhara M K <muralimk@amd.com> > > Add Aldebaran device to the PCI ID database. Since this device has a > configurable PCIe endpoint, it could be used with different drivers. > > Signed-off-by: Muralidhara M K <muralimk@amd.com> > Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com> > --- > include/linux/pci_ids.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index > 4bac1831de80..d9aae90dfce9 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -554,6 +554,7 @@ > #define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493 #define > PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b #define > PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443 > +#define PCI_DEVICE_ID_AMD_ALDEBARAN_DF_F3 0x14d3 > #define PCI_DEVICE_ID_AMD_19H_DF_F3 0x1653 > #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d > #define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703 > -- The PCI ID looks right. But I think this patch can be part of the next patch where this value is first used. [naveenk:] Squashed this change into the 2nd patch and submitted v2 https://patchwork.kernel.org/project/linux-edac/patch/20210806074350.114614-2-nchatrad@amd.com/ Thanks, Yazen
On Tue, Aug 10, 2021 at 12:45:17PM +0000, Chatradhi, Naveen Krishna wrote: > But I think this patch can be part of the next patch > where this value is first used. [naveenk:] Squashed > this change into the 2nd patch and submitted v2 > https://patchwork.kernel.org/project/linux-edac/patch/20210806074350.1 > 14614-2-nchatrad@amd.com/ Btw, I'd suggest you find someone at AMD to teach you to use a proper mail client for replying to lkml messages which does proper quoting, etc. Outlook and windoze simply isn't cut out for this type of communication but rather for managerial blabla. Alternatively, you can read this here: https://www.kernel.org/doc/html/latest/process/email-clients.html and try to set up something yourself. Thx.
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 4bac1831de80..d9aae90dfce9 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -554,6 +554,7 @@ #define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493 #define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b #define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443 +#define PCI_DEVICE_ID_AMD_ALDEBARAN_DF_F3 0x14d3 #define PCI_DEVICE_ID_AMD_19H_DF_F3 0x1653 #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d #define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703