| Message ID | 20210706050833.9852-1-jinpu.wang@ionos.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC/amd64: Do not load EDAC driver when running as a guest | expand |
On Tue, Jul 06, 2021 at 07:08:33AM +0200, Jack Wang wrote: > Similar to commit f0a029fff4a5 ("EDAC/Intel: Do not load EDAC driver when running as a guest") > > There's little to no point in loading an EDAC driver running in a guest. > > Add a check in each of the Intel EDAC drivers for X86_FEATURE_HYPERVISOR > and simply return -ENODEV in the init routine. Did you even read this sentence before leaving it in the commit message or you simply copied the commit message of f0a029fff4a5 blindly? Also: https://lore.kernel.org/linux-edac/20210628172740.245689-1-Smita.KoralahalliChannabasappa@amd.com/
On Tue, Jul 6, 2021 at 7:34 AM Borislav Petkov <bp@alien8.de> wrote: > > On Tue, Jul 06, 2021 at 07:08:33AM +0200, Jack Wang wrote: > > Similar to commit f0a029fff4a5 ("EDAC/Intel: Do not load EDAC driver when running as a guest") > > > > There's little to no point in loading an EDAC driver running in a guest. > > > > Add a check in each of the Intel EDAC drivers for X86_FEATURE_HYPERVISOR > > and simply return -ENODEV in the init routine. > > Did you even read this sentence before leaving it in the commit message > or you simply copied the commit message of f0a029fff4a5 blindly? sorry, I notice the patch for Intel, and feel we should do the same for AMD, hence post the patch. I forgot to adapt the content of the commit message. -.- > > Also: > > https://lore.kernel.org/linux-edac/20210628172740.245689-1-Smita.KoralahalliChannabasappa@amd.com/ > Great if it's already in the queue. > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette Thanks!
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index f0d8f60acee1..cdb14575ef31 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -3942,6 +3942,9 @@ static int __init amd64_edac_init(void) if (owner && strncmp(owner, EDAC_MOD_STR, sizeof(EDAC_MOD_STR))) return -EBUSY; + if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) + return -ENODEV; + if (!x86_match_cpu(amd64_cpuids)) return -ENODEV;
Similar to commit f0a029fff4a5 ("EDAC/Intel: Do not load EDAC driver when running as a guest") There's little to no point in loading an EDAC driver running in a guest. Add a check in each of the Intel EDAC drivers for X86_FEATURE_HYPERVISOR and simply return -ENODEV in the init routine. Signed-off-by: Jack Wang <jinpu.wang@ionos.com> --- drivers/edac/amd64_edac.c | 3 +++ 1 file changed, 3 insertions(+)