| Message ID | 20210818072315.15149-1-shubhrajyoti.datta@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] edac: synopsys: Fix the wrong value assignment for edac_mode | expand |
On Wed, Aug 18, 2021 at 12:53:14PM +0530, Shubhrajyoti Datta wrote: > From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> > > This patch corrected the edac_mode value by using enum instead of bitmask. I've fixed it up now but for the future, please avoid having "This patch" or "This commit" in the commit message. It is tautologically useless. Also, do $ git grep 'This patch' Documentation/process for more details. > Addresses-coverity: enumerated type mixed with another type. > Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > --- > drivers/edac/synopsys_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c > index 7e7146b22c16..7d08627e738b 100644 > --- a/drivers/edac/synopsys_edac.c > +++ b/drivers/edac/synopsys_edac.c > @@ -782,7 +782,7 @@ static void init_csrows(struct mem_ctl_info *mci) > > for (j = 0; j < csi->nr_channels; j++) { > dimm = csi->channels[j]->dimm; > - dimm->edac_mode = EDAC_FLAG_SECDED; > + dimm->edac_mode = EDAC_SECDED; > dimm->mtype = p_data->get_mtype(priv->baseaddr); > dimm->nr_pages = (size >> PAGE_SHIFT) / csi->nr_channels; > dimm->grain = SYNPS_EDAC_ERR_GRAIN; > -- Applied, thanks.
diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 7e7146b22c16..7d08627e738b 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -782,7 +782,7 @@ static void init_csrows(struct mem_ctl_info *mci) for (j = 0; j < csi->nr_channels; j++) { dimm = csi->channels[j]->dimm; - dimm->edac_mode = EDAC_FLAG_SECDED; + dimm->edac_mode = EDAC_SECDED; dimm->mtype = p_data->get_mtype(priv->baseaddr); dimm->nr_pages = (size >> PAGE_SHIFT) / csi->nr_channels; dimm->grain = SYNPS_EDAC_ERR_GRAIN;