| Message ID | 20210913021311.12896-1-mukul.joshi@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [PATCHv2,1/2] x86/MCE/AMD: Export smca_get_bank_type symbol | expand |
On Sun, Sep 12, 2021 at 10:13:10PM -0400, Mukul Joshi wrote: > Export smca_get_bank_type for use in the AMD GPU > driver to determine MCA bank while handling correctable > and uncorrectable errors in GPU UMC. > > v1->v2: > - Drop the function is_smca_umc_v2(). > - Drop the patch to introduce a new MCE priority (MCE_PRIO_ACEL) > for GPU/accelarator cards. Patch changelog information goes... > > Signed-off-by: Mukul Joshi <mukul.joshi@amd.com> > --- ... under this line so that it gets automatically removed by git when applying the patch. Alex, how do you wanna handle this? Want me to ACK this and you can carry it through your tree along with the second patch?
[Public] > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of > Borislav Petkov > Sent: Wednesday, September 22, 2021 7:34 AM > To: Joshi, Mukul <Mukul.Joshi@amd.com>; Alex Deucher > <alexdeucher@gmail.com> > Cc: linux-edac@vger.kernel.org; x86@kernel.org; linux- > kernel@vger.kernel.org; mingo@redhat.com; mchehab@kernel.org; > Ghannam, Yazen <Yazen.Ghannam@amd.com>; amd- > gfx@lists.freedesktop.org > Subject: Re: [PATCHv2 1/2] x86/MCE/AMD: Export smca_get_bank_type > symbol > > On Sun, Sep 12, 2021 at 10:13:10PM -0400, Mukul Joshi wrote: > > Export smca_get_bank_type for use in the AMD GPU driver to determine > > MCA bank while handling correctable and uncorrectable errors in GPU > > UMC. > > > > v1->v2: > > - Drop the function is_smca_umc_v2(). > > - Drop the patch to introduce a new MCE priority (MCE_PRIO_ACEL) > > for GPU/accelarator cards. > > Patch changelog information goes... > > > > > Signed-off-by: Mukul Joshi <mukul.joshi@amd.com> > > --- > > ... under this line so that it gets automatically removed by git when applying > the patch. > > Alex, how do you wanna handle this? > > Want me to ACK this and you can carry it through your tree along with the > second patch? That would be great. Thanks! Alex > > -- > Regards/Gruss, > Boris. > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeo > ple.kernel.org%2Ftglx%2Fnotes-about- > netiquette&data=04%7C01%7Calexander.deucher%40amd.com%7C12b > cf4eeffad4e2533b508d97dca1cf4%7C3dd8961fe4884e608e11a82d994e183d% > 7C0%7C0%7C637679129761221057%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C200 > 0&sdata=tK9aK%2FHf5RimF%2FenuTGeJSFFmRuk86Q%2BqY9Jt23gKMQ > %3D&reserved=0
On Wed, Sep 22, 2021 at 04:27:34PM +0000, Deucher, Alexander wrote: > > On Sun, Sep 12, 2021 at 10:13:10PM -0400, Mukul Joshi wrote: > > > Export smca_get_bank_type for use in the AMD GPU driver to determine > > > MCA bank while handling correctable and uncorrectable errors in GPU > > > UMC. > > > > > > v1->v2: > > > - Drop the function is_smca_umc_v2(). > > > - Drop the patch to introduce a new MCE priority (MCE_PRIO_ACEL) > > > for GPU/accelarator cards. > > > > Patch changelog information goes... > > > > > > > > Signed-off-by: Mukul Joshi <mukul.joshi@amd.com> > > > --- > > > > ... under this line so that it gets automatically removed by git when applying > > the patch. > > > > Alex, how do you wanna handle this? > > > > Want me to ACK this and you can carry it through your tree along with the > > second patch? > > That would be great. Thanks! Ok, with the above changelog removed: Acked-by: Borislav Petkov <bp@suse.de> Thx.
[AMD Official Use Only] > -----Original Message----- > From: Borislav Petkov <bp@alien8.de> > Sent: Wednesday, September 22, 2021 12:44 PM > To: Deucher, Alexander <Alexander.Deucher@amd.com> > Cc: Joshi, Mukul <Mukul.Joshi@amd.com>; Alex Deucher > <alexdeucher@gmail.com>; linux-edac@vger.kernel.org; x86@kernel.org; linux- > kernel@vger.kernel.org; mingo@redhat.com; mchehab@kernel.org; Ghannam, > Yazen <Yazen.Ghannam@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCHv2 1/2] x86/MCE/AMD: Export smca_get_bank_type symbol > > [CAUTION: External Email] > > On Wed, Sep 22, 2021 at 04:27:34PM +0000, Deucher, Alexander wrote: > > > On Sun, Sep 12, 2021 at 10:13:10PM -0400, Mukul Joshi wrote: > > > > Export smca_get_bank_type for use in the AMD GPU driver to > > > > determine MCA bank while handling correctable and uncorrectable > > > > errors in GPU UMC. > > > > > > > > v1->v2: > > > > - Drop the function is_smca_umc_v2(). > > > > - Drop the patch to introduce a new MCE priority (MCE_PRIO_ACEL) > > > > for GPU/accelarator cards. > > > > > > Patch changelog information goes... > > > > > > > > > > > Signed-off-by: Mukul Joshi <mukul.joshi@amd.com> > > > > --- > > > > > > ... under this line so that it gets automatically removed by git > > > when applying the patch. > > > > > > Alex, how do you wanna handle this? > > > > > > Want me to ACK this and you can carry it through your tree along > > > with the second patch? > > > > That would be great. Thanks! > > Ok, with the above changelog removed: > > Acked-by: Borislav Petkov <bp@suse.de> > > Thx. > Thank you so much! I will make sure to remove the changelog. And I will send the updated version for the second patch soon. Regards, Mukul > -- > Regards/Gruss, > Boris. > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople. > kernel.org%2Ftglx%2Fnotes-about- > netiquette&data=04%7C01%7CMukul.Joshi%40amd.com%7C3dc61ec5018f > 487ec06e08d97de83039%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0 > %7C637679258473597532%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata > =4JqFDJpxM%2Bzl4%2BZoaC3tTwScEhRy2Aa7xJaNJn3rxbE%3D&reserved= > 0
diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h index fc3d36f1f9d0..d90d3ccb583a 100644 --- a/arch/x86/include/asm/mce.h +++ b/arch/x86/include/asm/mce.h @@ -358,7 +358,7 @@ extern int mce_threshold_remove_device(unsigned int cpu); void mce_amd_feature_init(struct cpuinfo_x86 *c); int umc_normaddr_to_sysaddr(u64 norm_addr, u16 nid, u8 umc, u64 *sys_addr); - +enum smca_bank_types smca_get_bank_type(unsigned int bank); #else static inline int mce_threshold_create_device(unsigned int cpu) { return 0; }; diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 67a337672ee4..c9272c53026e 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -123,7 +123,7 @@ const char *smca_get_long_name(enum smca_bank_types t) } EXPORT_SYMBOL_GPL(smca_get_long_name); -static enum smca_bank_types smca_get_bank_type(unsigned int bank) +enum smca_bank_types smca_get_bank_type(unsigned int bank) { struct smca_bank *b; @@ -136,6 +136,7 @@ static enum smca_bank_types smca_get_bank_type(unsigned int bank) return b->hwid->bank_type; } +EXPORT_SYMBOL_GPL(smca_get_bank_type); static struct smca_hwid smca_hwid_mcatypes[] = { /* { bank_type, hwid_mcatype } */
Export smca_get_bank_type for use in the AMD GPU driver to determine MCA bank while handling correctable and uncorrectable errors in GPU UMC. v1->v2: - Drop the function is_smca_umc_v2(). - Drop the patch to introduce a new MCE priority (MCE_PRIO_ACEL) for GPU/accelarator cards. Signed-off-by: Mukul Joshi <mukul.joshi@amd.com> --- arch/x86/include/asm/mce.h | 2 +- arch/x86/kernel/cpu/mce/amd.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)