| Message ID | 20210915232739.6367-6-Smita.KoralahalliChannabasappa@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86/mce: Handle error simulation failures in mce-inject module | expand |
On Wed, Sep 15, 2021 at 06:27:39PM -0500, Smita Koralahalli wrote: > Currently, the mce-inject module fails silently and user must look for > kernel logs to determine if the injection has succeeded. > > Save time for the user and return error code from the module if error > injection fails. > > Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com> > --- > arch/x86/kernel/cpu/mce/inject.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c > index c7d1564f244b..0ef9ff921c6a 100644 > --- a/arch/x86/kernel/cpu/mce/inject.c > +++ b/arch/x86/kernel/cpu/mce/inject.c > @@ -549,8 +549,10 @@ static void do_inject(void) > } > > cpus_read_lock(); > - if (!cpu_online(cpu)) > + if (!cpu_online(cpu)) { > + mce_err.err = -ENODEV; You could issue a pr_err() here too. That ENODEV probably turns into "write failed" but that doesn't say why.
diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c index c7d1564f244b..0ef9ff921c6a 100644 --- a/arch/x86/kernel/cpu/mce/inject.c +++ b/arch/x86/kernel/cpu/mce/inject.c @@ -549,8 +549,10 @@ static void do_inject(void) } cpus_read_lock(); - if (!cpu_online(cpu)) + if (!cpu_online(cpu)) { + mce_err.err = -ENODEV; goto err; + } toggle_hw_mce_inject(cpu, true); @@ -622,7 +624,7 @@ static int inj_bank_set(void *data, u64 val) /* Reset injection struct */ setup_inj_struct(&i_mce); - return 0; + return mce_err.err; } MCE_INJECT_GET(bank);
Currently, the mce-inject module fails silently and user must look for kernel logs to determine if the injection has succeeded. Save time for the user and return error code from the module if error injection fails. Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com> --- arch/x86/kernel/cpu/mce/inject.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)