| Message ID | 20220421135319.1508754-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC/ghes: change ghes_hw from global to static | expand |
On Thu, Apr 21, 2022 at 09:53:19AM -0400, Tom Rix wrote: > Smatch reports this issue > ghes_edac.c:44:3: warning: symbol 'ghes_hw' was not declared. Should it be static? > > ghes_hw is only used in ghes_edac.c so change its > storage-class specifier to static. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/edac/ghes_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c > index 2805d5610300..59b0bedc9c24 100644 > --- a/drivers/edac/ghes_edac.c > +++ b/drivers/edac/ghes_edac.c > @@ -38,7 +38,7 @@ static struct ghes_pvt *ghes_pvt; > * This driver's representation of the system hardware, as collected > * from DMI. > */ > -struct ghes_hw_desc { > +static struct ghes_hw_desc { > int num_dimms; > struct dimm_info *dimms; > } ghes_hw; > -- Applied, thanks.
diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c index 2805d5610300..59b0bedc9c24 100644 --- a/drivers/edac/ghes_edac.c +++ b/drivers/edac/ghes_edac.c @@ -38,7 +38,7 @@ static struct ghes_pvt *ghes_pvt; * This driver's representation of the system hardware, as collected * from DMI. */ -struct ghes_hw_desc { +static struct ghes_hw_desc { int num_dimms; struct dimm_info *dimms; } ghes_hw;
Smatch reports this issue ghes_edac.c:44:3: warning: symbol 'ghes_hw' was not declared. Should it be static? ghes_hw is only used in ghes_edac.c so change its storage-class specifier to static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/edac/ghes_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)