diff mbox series

EDAC,wq: remove unneeded flush_workqueue

Message ID 20220424062127.3219542-1-ran.jianping@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series EDAC,wq: remove unneeded flush_workqueue | expand

Commit Message

CGEL April 24, 2022, 6:21 a.m. UTC 
From: ran jianping <ran.jianping@zte.com.cn>

All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
 drivers/edac/wq.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Borislav Petkov Aug. 25, 2022, 8:58 a.m. UTC | #1 
On Sun, Apr 24, 2022 at 06:21:26AM +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
> 
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
> ---
>  drivers/edac/wq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c
> index d021d287eaec..ad3f516627c5 100644
> --- a/drivers/edac/wq.c
> +++ b/drivers/edac/wq.c
> @@ -37,7 +37,6 @@ int edac_workqueue_setup(void)
>  
>  void edac_workqueue_teardown(void)
>  {
> -	flush_workqueue(wq);
>  	destroy_workqueue(wq);
>  	wq = NULL;
>  }
> -- 

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c
index d021d287eaec..ad3f516627c5 100644
--- a/drivers/edac/wq.c
+++ b/drivers/edac/wq.c
@@ -37,7 +37,6 @@  int edac_workqueue_setup(void)
 
 void edac_workqueue_teardown(void)
 {
-	flush_workqueue(wq);
 	destroy_workqueue(wq);
 	wq = NULL;
 }