| Message ID | 20220503094728.926-2-ctcchien@nuvoton.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC: nuvoton: Add nuvoton NPCM memory controller driver | expand |
Dear Medad, Thank you for v8. Am 03.05.22 um 11:47 schrieb Medad CChien: > ECC must be configured in the BootBlock header. > Then, you can read error counts via > the EDAC kernel framework. Please reflow for 75 characters per line. […] Kind regards, Paul
On Tue, May 03, 2022 at 05:47:26PM +0800, Medad CChien wrote: > ECC must be configured in the BootBlock header. > Then, you can read error counts via > the EDAC kernel framework. > > Signed-off-by: Medad CChien <ctcchien@nuvoton.com> > Reviewed-by: Borislav Petkov <bp@alien8.de> > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> I don't think you understand the concept of Reviewed-by: tags. You may add them to a patch of yours when the reviewer gives them to you explicitly - not because she/he has given comments to a patch of yours. Please go over Documentation/process/ and Documentation/process/submitting-patches.rst especially and then send patches. Thx.
Dear Paul, Paul Menzel <pmenzel@molgen.mpg.de> 於 2022年5月3日 週二 下午5:56寫道： > > Dear Medad, > > > Thank you for v8. > > Am 03.05.22 um 11:47 schrieb Medad CChien: > > ECC must be configured in the BootBlock header. > > Then, you can read error counts via > > the EDAC kernel framework. > > Please reflow for 75 characters per line. OK, I will reflow for 75 characters per line. > > […] > > > Kind regards, > > Paul B.R. Medad
Dear Borislav, Borislav Petkov <bp@alien8.de> 於 2022年5月3日 週二 下午6:15寫道： > > On Tue, May 03, 2022 at 05:47:26PM +0800, Medad CChien wrote: > > ECC must be configured in the BootBlock header. > > Then, you can read error counts via > > the EDAC kernel framework. > > > > Signed-off-by: Medad CChien <ctcchien@nuvoton.com> > > Reviewed-by: Borislav Petkov <bp@alien8.de> > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> > > I don't think you understand the concept of Reviewed-by: tags. You > may add them to a patch of yours when the reviewer gives them to you > explicitly - not because she/he has given comments to a patch of yours. > > Please go over > > Documentation/process/ > > and Documentation/process/submitting-patches.rst especially and then > send patches. > > Thx. > Sorry, I did misunderstand the concept of Reviewed-by: tags. I will revise thanks > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette B.R. Medad
diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi index 3696980a3da1..ba542b26941e 100644 --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi @@ -106,6 +106,13 @@ interrupt-parent = <&gic>; ranges; + mc: memory-controller@f0824000 { + compatible = "nuvoton,npcm750-memory-controller"; + reg = <0x0 0xf0824000 0x0 0x1000>; + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + rstc: rstc@f0801000 { compatible = "nuvoton,npcm750-reset"; reg = <0xf0801000 0x70>;