| Message ID | 20230129165054.1675554-1-j.neuschaefer@gmx.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR | expand |
On Sun, Jan 29, 2023 at 05:50:54PM +0100, Jonathan Neuschäfer wrote: > MODULE_AUTHOR strings don't usually include a newline character. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > --- > drivers/edac/amd8111_edac.c | 2 +- > drivers/edac/amd8131_edac.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/edac/amd8111_edac.c b/drivers/edac/amd8111_edac.c > index 7508aa416ddbd..ca718f63fcbcd 100644 > --- a/drivers/edac/amd8111_edac.c > +++ b/drivers/edac/amd8111_edac.c > @@ -593,5 +593,5 @@ module_init(amd8111_edac_init); > module_exit(amd8111_edac_exit); > > MODULE_LICENSE("GPL"); > -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n"); > +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>"); > MODULE_DESCRIPTION("AMD8111 HyperTransport I/O Hub EDAC kernel module"); > diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c > index 1693537109826..28610ba514f4d 100644 > --- a/drivers/edac/amd8131_edac.c > +++ b/drivers/edac/amd8131_edac.c > @@ -354,5 +354,5 @@ module_init(amd8131_edac_init); > module_exit(amd8131_edac_exit); > > MODULE_LICENSE("GPL"); > -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n"); > +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>"); > MODULE_DESCRIPTION("AMD8131 HyperTransport PCI-X Tunnel EDAC kernel module"); > -- Wanna fix the other two in the EDAC tree: drivers/edac/e752x_edac.c:1465:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Tom Zimmerman\n"); drivers/edac/e7xxx_edac.c:599:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Thayne Harbaugh et al\n" ? That macro takes: /* * Author(s), use "Name <email>" or just "Name", for multiple * authors use multiple MODULE_AUTHOR() statements/lines. */ #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) and not prose. You can move the prose to the top comment in the respective file, if it doesn't contain it yet. Thx.
On Sun, Jan 29, 2023 at 05:50:54PM +0100, Jonathan Neuschäfer wrote: > MODULE_AUTHOR strings don't usually include a newline character. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > --- > drivers/edac/amd8111_edac.c | 2 +- > drivers/edac/amd8131_edac.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/edac/amd8111_edac.c b/drivers/edac/amd8111_edac.c > index 7508aa416ddbd..ca718f63fcbcd 100644 > --- a/drivers/edac/amd8111_edac.c > +++ b/drivers/edac/amd8111_edac.c > @@ -593,5 +593,5 @@ module_init(amd8111_edac_init); > module_exit(amd8111_edac_exit); > > MODULE_LICENSE("GPL"); > -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n"); > +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>"); > MODULE_DESCRIPTION("AMD8111 HyperTransport I/O Hub EDAC kernel module"); > diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c > index 1693537109826..28610ba514f4d 100644 > --- a/drivers/edac/amd8131_edac.c > +++ b/drivers/edac/amd8131_edac.c > @@ -354,5 +354,5 @@ module_init(amd8131_edac_init); > module_exit(amd8131_edac_exit); > > MODULE_LICENSE("GPL"); > -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n"); > +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>"); > MODULE_DESCRIPTION("AMD8131 HyperTransport PCI-X Tunnel EDAC kernel module"); > -- Applied, thanks.
On Sun, Mar 19, 2023 at 08:20:11PM +0100, Borislav Petkov wrote: > On Sun, Jan 29, 2023 at 05:50:54PM +0100, Jonathan Neuschäfer wrote: [...] > Wanna fix the other two in the EDAC tree: > > drivers/edac/e752x_edac.c:1465:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Tom Zimmerman\n"); > drivers/edac/e7xxx_edac.c:599:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Thayne Harbaugh et al\n" > > ? > > That macro takes: > > /* > * Author(s), use "Name <email>" or just "Name", for multiple > * authors use multiple MODULE_AUTHOR() statements/lines. > */ > #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) > > and not prose. > > You can move the prose to the top comment in the respective file, if it > doesn't contain it yet. > > Thx. Sorry for the late reply. I'm replying now because I saw that you applied the patch. I might fix the above if/when I get around to it, but there's currently no guarantee of that. Best regards, Jonathan
On Tue, Mar 28, 2023 at 09:26:37PM +0200, Jonathan Neuschäfer wrote: > I might fix the above if/when I get around to it, but there's currently > no guarantee of that. No need, already took care of them all, while at it. Thanks.
diff --git a/drivers/edac/amd8111_edac.c b/drivers/edac/amd8111_edac.c index 7508aa416ddbd..ca718f63fcbcd 100644 --- a/drivers/edac/amd8111_edac.c +++ b/drivers/edac/amd8111_edac.c @@ -593,5 +593,5 @@ module_init(amd8111_edac_init); module_exit(amd8111_edac_exit); MODULE_LICENSE("GPL"); -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n"); +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>"); MODULE_DESCRIPTION("AMD8111 HyperTransport I/O Hub EDAC kernel module"); diff --git a/drivers/edac/amd8131_edac.c b/drivers/edac/amd8131_edac.c index 1693537109826..28610ba514f4d 100644 --- a/drivers/edac/amd8131_edac.c +++ b/drivers/edac/amd8131_edac.c @@ -354,5 +354,5 @@ module_init(amd8131_edac_init); module_exit(amd8131_edac_exit); MODULE_LICENSE("GPL"); -MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>\n"); +MODULE_AUTHOR("Cao Qingtao <qingtao.cao@windriver.com>"); MODULE_DESCRIPTION("AMD8131 HyperTransport PCI-X Tunnel EDAC kernel module");
MODULE_AUTHOR strings don't usually include a newline character. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- drivers/edac/amd8111_edac.c | 2 +- drivers/edac/amd8131_edac.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.39.0