From patchwork Sat Jun 10 21:09:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13275094 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF50C7EE29 for ; Sat, 10 Jun 2023 21:10:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232115AbjFJVK2 (ORCPT ); Sat, 10 Jun 2023 17:10:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjFJVK1 (ORCPT ); Sat, 10 Jun 2023 17:10:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B446C30F8 for ; Sat, 10 Jun 2023 14:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686431378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=whk8LCDI/O2jXvvaBN0dOJYkF+7e5dfH9oNJPu7ipD8=; b=isnlwTrc2poQmUliVrMy3ttu2yXSEUNgCt5qAJNM/Gz7aYGl6K4vy5xM4ugGBxwmIYg4cn F6F0MN9+CrpJlL4Nov2cgtGCONSKX+cRjduYk6xYfC6NxlElwDIlBxZ01XUAGHPD+j2J0c iUGwSihQ2g4SpGWJiMyU35l1aa+9/6w= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-4uttOoqhNeWG4vEhbyMO7g-1; Sat, 10 Jun 2023 17:09:37 -0400 X-MC-Unique: 4uttOoqhNeWG4vEhbyMO7g-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-75d51a46b63so478004485a.1 for ; Sat, 10 Jun 2023 14:09:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686431376; x=1689023376; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=whk8LCDI/O2jXvvaBN0dOJYkF+7e5dfH9oNJPu7ipD8=; b=XZ9znJpLThF30A0AURzw9p6R5IzOjC3AmBgQEf3tfpQb06NEm8SKMwwiyLJNVGRsjf dYdODPsTiM7lX3Fw77bZjSx0ZMm/WbEZ8BLM0f6O9K6yfmhmNvjsxIXpz0d6Dd56aXca ElvUMjVuHKDw44YMB3CjF5Jz/hOMctVtx8MuIe87HeXnRlzXwBk4hHv+hFjlgAmC9hB1 bj+ZvA8+T/6hcDyof4wFpOiG2CxF/G7Bk63uXircLY0Fy+Pa9iAa43aEDDLKFmdTRgaF 1VxH1Qnc4u6UO/G01JiUXS1bQe+SlbDuWVszpfBmCVAouV6MFzeeaM1UYU6XA3kHLiwu Q4JQ== X-Gm-Message-State: AC+VfDwaht4m+u7YlrpY0ydu0lRtci2y3yD0i8IbO2UMytdgf1gP4KZY PzJWer8IpY1Nod0HuAvzm/M78R9EVgr7FUpIuHfCdlKcpkggwd1cFZrjoYk52cvcnI7dxjlJz/Y KZe+wTEGzbc0XOou+Dlsn1w== X-Received: by 2002:ac8:57cc:0:b0:3f9:7251:30f4 with SMTP id w12-20020ac857cc000000b003f9725130f4mr6276322qta.4.1686431376742; Sat, 10 Jun 2023 14:09:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6/m5cQYtKIkm5rXShhXYKAKgeTgWN14pGp1pXpg4ts/5g4vJjRVW2y96C7y3gT18cObtLJGA== X-Received: by 2002:ac8:57cc:0:b0:3f9:7251:30f4 with SMTP id w12-20020ac857cc000000b003f9725130f4mr6276306qta.4.1686431376496; Sat, 10 Jun 2023 14:09:36 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id d20-20020ac84e34000000b003f6ac526568sm2187472qtw.39.2023.06.10.14.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jun 2023 14:09:36 -0700 (PDT) From: Tom Rix To: yazen.ghannam@amd.com, bp@alien8.de, tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] EDAC/amd64: set variable gpu_node_map storage-class-specifier to static Date: Sat, 10 Jun 2023 17:09:30 -0400 Message-Id: <20230610210930.174074-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-edac@vger.kernel.org smatch reports drivers/edac/amd64_edac.c:990:3: warning: symbol 'gpu_node_map' was not declared. Should it be static? This variable is only used in its defining file, so it should be static. Signed-off-by: Tom Rix Reviewed-by: Yazen Ghannam --- drivers/edac/amd64_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 5d7c080d96a2..597dae7692b1 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -984,7 +984,7 @@ static int sys_addr_to_csrow(struct mem_ctl_info *mci, u64 sys_addr) * system and what the lowest AMD Node ID value is for the GPU nodes. Use this * info to fixup the Linux logical "Node ID" value set in the AMD NB code and EDAC. */ -struct local_node_map { +static struct local_node_map { u16 node_count; u16 base_node_id; } gpu_node_map;