| Message ID | 20250106053358.21664-2-shubhrajyoti.datta@amd.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | EDAC: Versal NET: Add support for error notification | expand |
On Mon, Jan 06, 2025 at 11:03:54AM +0530, Shubhrajyoti Datta wrote:
> export the symbols for modules.
Which modules are going to use those? Why?
Why is this patch in this set?
This commit message is largely inadequate. Your other commit messages too.
Yeah, the goal is for our commit messages to be as clear to humans as
possible, even for people who do not have intimate knowledge of the matter.
And, more importantly, when we start doing git archeology months, years from
now, it should be perfectly clear why a commit was done.
So please try to explain the issue in a clear and detailed way.
People and you yourself will be thankful for it.
diff --git a/drivers/cdx/controller/mcdi.c b/drivers/cdx/controller/mcdi.c index e760f8d347cc..e819049df659 100644 --- a/drivers/cdx/controller/mcdi.c +++ b/drivers/cdx/controller/mcdi.c @@ -128,6 +128,7 @@ int cdx_mcdi_init(struct cdx_mcdi *cdx) fail: return rc; } +EXPORT_SYMBOL_GPL(cdx_mcdi_init); void cdx_mcdi_finish(struct cdx_mcdi *cdx) { @@ -590,6 +591,7 @@ void cdx_mcdi_process_cmd(struct cdx_mcdi *cdx, struct cdx_dword *outbuf, int le cdx_mcdi_process_cleanup_list(mcdi->cdx, &cleanup_list); } +EXPORT_SYMBOL_GPL(cdx_mcdi_process_cmd); static void cdx_mcdi_cmd_work(struct work_struct *context) { @@ -757,6 +759,7 @@ int cdx_mcdi_rpc(struct cdx_mcdi *cdx, unsigned int cmd, return cdx_mcdi_rpc_sync(cdx, cmd, inbuf, inlen, outbuf, outlen, outlen_actual, false); } +EXPORT_SYMBOL_GPL(cdx_mcdi_rpc); /** * cdx_mcdi_rpc_async - Schedule an MCDI command to run asynchronously
export the symbols for modules. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> --- (no changes since v2) Changes in v2: - Export the symbols for module compilation drivers/cdx/controller/mcdi.c | 3 +++ 1 file changed, 3 insertions(+)