From patchwork Tue Feb 1 18:59:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helge Deller X-Patchwork-Id: 12732170 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE32CC433F5 for ; Tue, 1 Feb 2022 19:00:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242168AbiBATAF (ORCPT ); Tue, 1 Feb 2022 14:00:05 -0500 Received: from mout.gmx.net ([212.227.17.20]:41271 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbiBATAF (ORCPT ); Tue, 1 Feb 2022 14:00:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643741996; bh=d2IztvFiozX9ikhPD2+aEcoaHd/2PejNuetOnFWjSAc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=JXbdahizytzLhrg4cTc6zH+bWwVy6d0whn8StbX2ptCJBrUsuFjAxvrHOUGDaDYdL oaEQ8UUbgZN139YUMpBRr2j4fXounTHzCUyeTIxBAE8iDuRgWi3CRqJQsQf+FZHsCs st9vIhFZQ3tDspClJFUjOYgpkFnO92A6xposou7U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from p100.fritz.box ([92.116.146.124]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M59C8-1nG4qG0UIm-001EP7; Tue, 01 Feb 2022 19:59:56 +0100 From: Helge Deller To: DRI Development , linux-fbdev@vger.kernel.org, Daniel Vetter Cc: James Bottomley , John David Anglin Subject: [PATCH v3 0/3] Fix regression introduced by disabling accelerated scrolling in fbcon Date: Tue, 1 Feb 2022 19:59:51 +0100 Message-Id: <20220201185954.169768-1-deller@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:qPvm+cPnCkp5vT9++/v4GQfSPVJnSRf0zFa4GEm8zKIGhM5meJk tAHuvYDRhc5aCbrPQGeToT/eOSt1j7jiHwhO3T5X6m9Agbsyt23eBJZlguNxg6m2r3lI5ES z3UqZ3XvN7Fdwn2LrQiZwedJmN7q65YYE/GPqV+aABLeg2CIKOfuo+6xAJJ7L8pLZTa0ovn M7wAfJmIqeZ1OC4ejY0rA== X-UI-Out-Filterresults: notjunk:1;V03:K0:955qTNaf9as=:+DzSxYCUeiqpBth/q0SAxK ZE8bOby63cYfSf8PWUVom5/cen/frCfUIoP77fPwQQJuFGjxYCaEANUl+AgsCS2NFkw8Li1t8 AmiYTGXhllCFeHmWui74HoCkIPGgnMsvSv6bTrP+aVE2kip62/Ljz6oLnOKyiEmjUZMBixs1r hwf/pFUObC6SuXY6Ss+m/ld3lCCGY6RllJV6XyTU6D57IMqIZJbW7CvU7YyZ98UnoxpORH2CL L3FNdpHGW7vfOLIBHIHZktRB7u3jFsx8IeGNuyLUMlRnI0r1006gKik0E5CI3VRNbiIL0Wd5i UQgGSgYBf4LolVxLpnofTK+BcnTaZtiO/VGb0kXHo+ElR2sYZHZzncoO+r8Y3XSyi+vZKfFh5 TAlF1iIAyxE7jNPfl8XzB2eeCVsyQx087XB+XOnsx2ct/RPqA7c8CG1HIcoXzTY0PZukqmeP6 uCEAnwFt/ymxP/dJn5oo22M0s8emXxzKwDabaUt4WbLwwZUSjRi9ex8zlsiVIA0zOoTCR3CwS iWTP7XmcfxJflmi6WewA+3iIw+BE0OzkZiva5FfXXmlJouQutpkKtl87ou4iUQmCECIIUNO4g PrglTU+Z8XgqXhSd+OFwODGQWQdYbeYHXtoiBjYAZXAXQzvxadh5MhHPbjYev1IgAQdv8z8Lo UtLr3FgDCpbv6mboUV/3T726yUNhMk0xOfBKgCrsThMna/Wu3a1IHGiTrqzaAWXwUHeZiPKjp dHy6thkqHzHeyD1ooypfuAqKqyuzndO9M4VbAAaIRPU2g+J7i8OhlMYj/dpR5kTO/rN/IOtuJ iO8NlqfjiAo8d9F8M/X61z5Dudw+gXmvzwlOS+IMa6N0zWsVIPq2S23CQUCdff3QWUl0k5fyb RnoH0BJR+za7CNCZ7uaCBCUIHvnZgpz+yaTi9wAUSTbjKTNktFDFXZvxLH+GgOU+Vg5VdANDf IbygF2r92zaYxf4w1VGW0UQ9Zbw9+wt4UchULCIZ1qWbMsPvRLz49ekNY26rQhFt2nn80FEoe Pt0Nxxi2BXcyWdTKrMl+Oi4xtH8M1K40FwHQerCavsF+uzIR3h8tPPGSLGcdjRoylnNgHJkoj kWaPUpHzcZMYwE= Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This series reverts two patches which disabled scrolling acceleration in fbcon/fbdev. Those patches introduced a regression for fbdev-supported graphic cards because of the performance penalty by doing screen scrolling by software instead of using existing 2D hardware acceleration. The third patch introduces a new config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION, which -if enabled- switches fbcon to utilize the bitblt and fillrect hardware acceleration in the framebuffer console. If disabled, such acceleration will not be used, even if it is supported by the graphics hardware driver. This series is being discussed on linux-fbdev and dri-devel mailing lists. Helge Helge Deller (3): Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" Revert "fbcon: Disable accelerated scrolling" fbcon: Add option to enable legacy hardware acceleration Documentation/gpu/todo.rst | 24 - drivers/video/console/Kconfig | 11 + drivers/video/fbdev/core/bitblit.c | 16 + drivers/video/fbdev/core/fbcon.c | 557 +++++++++++++++++++++++- drivers/video/fbdev/core/fbcon.h | 72 +++ drivers/video/fbdev/core/fbcon_ccw.c | 28 +- drivers/video/fbdev/core/fbcon_cw.c | 28 +- drivers/video/fbdev/core/fbcon_rotate.h | 9 + drivers/video/fbdev/core/fbcon_ud.c | 37 +- drivers/video/fbdev/core/tileblit.c | 16 + drivers/video/fbdev/skeletonfb.c | 12 +- include/linux/fb.h | 2 +- 12 files changed, 744 insertions(+), 68 deletions(-)