From patchwork Thu Sep 12 07:27:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876641 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D897BBF43F for ; Thu, 12 Sep 2013 07:27:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D12C9202BE for ; Thu, 12 Sep 2013 07:27:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36694202B9 for ; Thu, 12 Sep 2013 07:27:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785Ab3ILH14 (ORCPT ); Thu, 12 Sep 2013 03:27:56 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:10521 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051Ab3ILH14 (ORCPT ); Thu, 12 Sep 2013 03:27:56 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT000M8A4Q8HF50@mailout4.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 16:27:54 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 22.7F.17682.AFC61325; Thu, 12 Sep 2013 16:27:54 +0900 (KST) X-AuditID: cbfee68e-b7f756d000004512-fa-52316cfab843 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 7E.59.05832.9FC61325; Thu, 12 Sep 2013 16:27:53 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT0005VU4QHVV00@mmp1.samsung.com>; Thu, 12 Sep 2013 16:27:53 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> <002001ceaf84$d5e9b450$81bd1cf0$%han@samsung.com> In-reply-to: <002001ceaf84$d5e9b450$81bd1cf0$%han@samsung.com> Subject: [PATCH 06/21] video: gx1fb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 16:27:54 +0900 Message-id: <000301ceaf89$98799bd0$c96cd370$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAAIqUwAAEtM3A= Content-language: ko x-cr-hashedpuzzle: CbOO CnNZ CtdC GZFN G1cJ H9Gn O/RH V3Li clz5 edix k+w2 m7bN pSrL pu+r qIeW seOl; 4; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGwAaQBuAHUAeAAtAGYAYgBkAGUAdgBAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcABsAGEAZwBuAGkAbwBqAEAAagBjAHIAbwBzAG8AZgB0AC4AYwBvAG0AOwB0AG8AbQBpAC4AdgBhAGwAawBlAGkAbgBlAG4AQAB0AGkALgBjAG8AbQA=; Sosha1_v1; 7; {8501B1E5-2ED2-4F56-B609-B4657A1BF2AB}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Thu, 12 Sep 2013 07:27:47 GMT; WwBQAEEAVABDAEgAIAAwADYALwAyADEAXQAgAHYAaQBkAGUAbwA6ACAAZwB4ADEAZgBiADoAIAByAGUAbQBvAHYAZQAgAHUAbgBuAGUAYwBlAHMAcwBhAHIAeQAgAHAAYwBpAF8AcwBlAHQAXwBkAHIAdgBkAGEAdABhACgAKQA= x-cr-puzzleid: {8501B1E5-2ED2-4F56-B609-B4657A1BF2AB} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsVy+t8zA91fOYZBBo9WM1tcXniJ1eJE3wdW i3UPXzBZrJ9/i82BxePVhTssHn1bVjF6HL+xncnj8ya5AJYoLpuU1JzMstQifbsEroxvvQtZ Cx6xVvz4/p65gfElSxcjJ4eEgInEhycfGSFsMYkL99azdTFycQgJLGOUWDD/IytM0dPeFewQ iUWMEot27ISq+sUosWT7N7B2NgE1iS9fDrOD2CICdhILL14C62YWyJfYsqQNzBYSKJR4v7Ib rIYTqGbL8d1gZwgLeEo0PDkJZrMIqErMO30QrIZXwFZi3uZTbBC2oMSPyfdYIGZqSazfeZwJ wpaX2LzmLXMXIwfQpeoSj/7qQpxgJfHt3ztmiBIRiX0v3jGC3CwhMIVV4tbx6ewQn5lKrDz0 ixki8ZJdYvmyrewQRwhIfJt8iAViqKzEpgPMEPWSEgdX3GCZwCg1C8lJs5CcNAvJSbOQ7F7A yLKKUTS1ILmgOCm9yEivODG3uDQvXS85P3cTIySS+3Yw3jxgfYgxGWj9RGYp0eR8YCLIK4k3 NDYzsjA1MTU2Mrc0I01YSZxXrcU6UEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAOjYY1Ydc/R 0Ebp34svqBWKXCvgf723cIPmIr8IP+EYDomo3t653Rd2zZip+M2DYfvn09O1jCbu/eoVuFrt rJH/cwFmtW8S3QzzZ3Q+uPkqpS9LdsvNhBkc/J++7NikvsDPzT+KtXvvcj2JruedKz4sVnj8 4+bvp2c/tLypYDU+6mrvlDFT4VmOEktxRqKhFnNRcSIA6K5fNvoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCKsWRmVeSWpSXmKPExsVy+t9jAd2fOYZBBrd32VhcXniJ1eJE3wdW i3UPXzBZrJ9/i82BxePVhTssHn1bVjF6HL+xncnj8ya5AJaoBkabjNTElNQihdS85PyUzLx0 WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCdSgpliTmlQKGAxOJiJX07TBNCQ9x0 LWAaI3R9Q4LgeowM0EDCOsaMb70LWQsesVb8+P6euYHxJUsXIyeHhICJxNPeFewQtpjEhXvr 2boYuTiEBBYxSizasRPK+cUosWT7N0aQKjYBNYkvXw6DdYgI2EksvHiJFcRmFsiX2LKkDcwW EiiUeL+yG6yGE6hmy/HdYNuEBTwlGp6cBLNZBFQl5p0+CFbDK2ArMW/zKTYIW1Dix+R7LBAz tSTW7zzOBGHLS2xe85a5i5ED6FJ1iUd/dSFOsJL49u8dM0SJiMS+F+8YQW6WEJjCKnHr+HSo z0wlVh76xTyBUWQWkhWzkKyYhWTFLCSzFjCyrGIUTS1ILihOSs810itOzC0uzUvXS87P3cQI ThPPpHcwrmqwOMQowMGoxMPbMcsgSIg1say4MvcQowQHs5IIb7y5YZAQb0piZVVqUX58UWlO avEhxmRgCExklhJNzgemsLySeENjEzMjSyMzCyMTc3PShJXEeQ+2WgcKCaQnlqRmp6YWpBbB bGHi4JRqYHRoW39hqs7rhjV+ETNW3b/6xWjNbNYLpRHq616o3c7isHsfGSYr2yPQe3dqfrep wF6f8Em3DiyTnlDXfk9jm7Qvw+WnSvf/hvCcPLsoMop59ympzVoenld/q4Rvbtuxz47hg+Xi 2A9MUv5rE5ND9C1vPDobddU+45tK2uqaKx1az2LctvNz31JiKc5INNRiLipOBACWblxvVwMA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/geode/gx1fb_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/geode/gx1fb_core.c b/drivers/video/geode/gx1fb_core.c index ebbaada..7551a04 100644 --- a/drivers/video/geode/gx1fb_core.c +++ b/drivers/video/geode/gx1fb_core.c @@ -399,7 +399,6 @@ static void gx1fb_remove(struct pci_dev *pdev) release_mem_region(gx1_gx_base() + 0x8300, 0x100); fb_dealloc_cmap(&info->cmap); - pci_set_drvdata(pdev, NULL); framebuffer_release(info); }