From patchwork Thu Sep 12 07:28:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876651 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2C244BF43F for ; Thu, 12 Sep 2013 07:28:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2FB37202DB for ; Thu, 12 Sep 2013 07:28:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 140ED202B9 for ; Thu, 12 Sep 2013 07:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288Ab3ILH23 (ORCPT ); Thu, 12 Sep 2013 03:28:29 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:13812 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051Ab3ILH22 (ORCPT ); Thu, 12 Sep 2013 03:28:28 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT000DBM4QU2980@mailout3.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 16:28:27 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.51]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 3E.48.20109.B1D61325; Thu, 12 Sep 2013 16:28:27 +0900 (KST) X-AuditID: cbfee68f-b7f1e6d000004e8d-05-52316d1b0ed2 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id E8.9E.09055.B1D61325; Thu, 12 Sep 2013 16:28:27 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT000J3X4RFQFJ0@mmp2.samsung.com>; Thu, 12 Sep 2013 16:28:27 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> <002801ceaf85$71f3d740$55db85c0$%han@samsung.com> In-reply-to: <002801ceaf85$71f3d740$55db85c0$%han@samsung.com> Subject: [PATCH 14/21] video: pm2fb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 16:28:27 +0900 Message-id: <000401ceaf89$ac6f2ab0$054d8010$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAATH9wAAENviA= Content-language: ko x-cr-hashedpuzzle: A1fA C6vv EzMW Ffw1 HqGs I8os KwaZ L1gi OLPP TvE1 aHm8 ezO2 mqkA mspd nJKE nlmQ; 4; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGwAaQBuAHUAeAAtAGYAYgBkAGUAdgBAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcABsAGEAZwBuAGkAbwBqAEAAagBjAHIAbwBzAG8AZgB0AC4AYwBvAG0AOwB0AG8AbQBpAC4AdgBhAGwAawBlAGkAbgBlAG4AQAB0AGkALgBjAG8AbQA=; Sosha1_v1; 7; {1073B59F-8E74-4652-8E1E-AB270EF7E0ED}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Thu, 12 Sep 2013 07:28:22 GMT; WwBQAEEAVABDAEgAIAAxADQALwAyADEAXQAgAHYAaQBkAGUAbwA6ACAAcABtADIAZgBiADoAIAByAGUAbQBvAHYAZQAgAHUAbgBuAGUAYwBlAHMAcwBhAHIAeQAgAHAAYwBpAF8AcwBlAHQAXwBkAHIAdgBkAGEAdABhACgAKQA= x-cr-puzzleid: {1073B59F-8E74-4652-8E1E-AB270EF7E0ED} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsVy+t8zY13pXMMggyWLJC0uL7zEanGi7wOr xbqHL5gs1s+/xebA4vHqwh0Wj74tqxg9jt/YzuTxeZNcAEsUl01Kak5mWWqRvl0CV0bjcZeC u6wVp99fYmxgfMLSxcjJISFgIvF41SY2CFtM4sK99WC2kMAyRonV95NgajrXbmPvYuQCik9n lPj8cxULhPOLUeLku21MIFVsAmoSX74cZgexRQTsJBZevMQKYjML5EtsWdLGCjG1UGLf7t2M IDYnUM3hpxuZQWxhAU+Jtq4/YDaLgKrE143zgOo5OHgFbCXenNIHCfMKCEr8mHyPBWKklsT6 nceZIGx5ic1r3jKDlEsIqEs8+qsLcYGVxPG2l2wQJSIS+168YwQ5WUJgCqtE7+7HUA+bSmyd eR0aEG/ZJVZN4IA4QUDi2+RDLBAzZSU2HWCGKJGUOLjiBssERqlZSC6aheSiWUgumoVk9QJG llWMoqkFyQXFSelFxnrFibnFpXnpesn5uZsYIRHcv4Px7gHrQ4zJQOsnMkuJJucDE0BeSbyh sZmRhamJqbGRuaUZacJK4rxqLdaBQgLpiSWp2ampBalF8UWlOanFhxiZODilGhgtBWzeNTBH rf14SWDngvY3/0LmMmmltl//Na3xtJZk39ptlZKzyvd+OnR/xelNG0LfN6acr+065dcoWyRV WvJi56WlCRXGNhc+x107y/Bi20wdJoaU1PNS1f1PnEKEK679XOpWfW3NJ/Zj1ufXXZ7xqnVp 6t5ruXqbd0/Mrwvt/GylGTfjtWy4EktxRqKhFnNRcSIA/djeIvYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEKsWRmVeSWpSXmKPExsVy+t9jQV3pXMMgg+ebRS0uL7zEanGi7wOr xbqHL5gs1s+/xebA4vHqwh0Wj74tqxg9jt/YzuTxeZNcAEtUA6NNRmpiSmqRQmpecn5KZl66 rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBOJYWyxJxSoFBAYnGxkr4dpgmhIW66 FjCNEbq+IUFwPUYGaCBhHWNG43GXgrusFaffX2JsYHzC0sXIySEhYCLRuXYbO4QtJnHh3nq2 LkYuDiGB6YwSn3+uYoFwfjFKnHy3jQmkik1ATeLLl8NgHSICdhILL15iBbGZBfIltixpA7OF BAol9u3ezQhicwLVHH66kRnEFhbwlGjr+gNmswioSnzdOA+onoODV8BW4s0pfZAwr4CgxI/J 91ggRmpJrN95nAnClpfYvOYtM0i5hIC6xKO/uhAXWEkcb3vJBlEiIrHvxTtGkJMlBKawSvTu fswG8ZipxNaZ11kmMIrMQrJiFpIVs5CsmIVk1gJGllWMoqkFyQXFSem5hnrFibnFpXnpesn5 uZsYwSnimdQOxpUNFocYBTgYlXh4O2YZBAmxJpYVV+YeYpTgYFYS4Y03NwwS4k1JrKxKLcqP LyrNSS0+xJgMDICJzFKiyfnA9JVXEm9obGJmZGlkZmFkYm5OmrCSOO+BVutAIYH0xJLU7NTU gtQimC1MHJxSDYx9gvqcczM8zFR9ZzfWPbk3fdaTshnBlseln+qzX846wplz87LCYX2JY1Vz f5isjdnEK7yrrr+4ZnqzXv60HdxX/HOWNP8w9fifWdq08s6Xq+bfna/uP6NYYPDVRL/6jP47 92I+t4Qvf24tka6duUPFY2FpVeEiwcSnkYciUzY0KNaGKgq+W6rEUpyRaKjFXFScCABP7mfY VQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/pm2fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/pm2fb.c b/drivers/video/pm2fb.c index 81354ee..45d9a3f 100644 --- a/drivers/video/pm2fb.c +++ b/drivers/video/pm2fb.c @@ -1744,7 +1744,6 @@ static void pm2fb_remove(struct pci_dev *pdev) iounmap(par->v_regs); release_mem_region(fix->mmio_start, fix->mmio_len); - pci_set_drvdata(pdev, NULL); fb_dealloc_cmap(&info->cmap); kfree(info->pixmap.addr); framebuffer_release(info);