From patchwork Wed Jan 8 00:44:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3450841 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 425969F374 for ; Wed, 8 Jan 2014 00:44:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 760A720120 for ; Wed, 8 Jan 2014 00:44:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5935620115 for ; Wed, 8 Jan 2014 00:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbaAHAoi (ORCPT ); Tue, 7 Jan 2014 19:44:38 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:42337 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbaAHAoi (ORCPT ); Tue, 7 Jan 2014 19:44:38 -0500 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MZ2004XQ4Q8D7C0@mailout2.samsung.com> for linux-fbdev@vger.kernel.org; Wed, 08 Jan 2014 09:44:32 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 06.C7.14803.F6F9CC25; Wed, 08 Jan 2014 09:44:31 +0900 (KST) X-AuditID: cbfee691-b7efc6d0000039d3-f9-52cc9f6f39e0 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 8B.00.29263.F6F9CC25; Wed, 08 Jan 2014 09:44:31 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MZ2000ZI4Q77H80@mmp1.samsung.com>; Wed, 08 Jan 2014 09:44:31 +0900 (KST) From: Jingoo Han To: 'Tomi Valkeinen' Cc: linux-fbdev@vger.kernel.org, 'Jean-Christophe PLAGNIOL-VILLARD' , 'Jingoo Han' Subject: [PATCH RESEND 1/4] video: asiliantfb: remove unnecessary pci_set_drvdata() Date: Wed, 08 Jan 2014 09:44:31 +0900 Message-id: <001901cf0c0a$cb48b5e0$61da21a0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac8MCsswVut/rfVlTMmgQ3JkQXU43Q== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t8zA938+WeCDDb9tba4vPASq8WJvg+s FusevmCyWD//FpsDi8erC3dYPPq2rGL0OH5jO5PH501yASxRXDYpqTmZZalF+nYJXBmrf/1g KnjLWvF94Su2BsbPLF2MnBwSAiYSZ+/dhrLFJC7cW8/WxcjFISSwjFFizfPzbDBFV/+dhUos YpQ48O4xK4Tzi1FidfctdpAqNgE1iS9fDoPZIgI6EpMW9TCDFDELNDNKbL72AWyHsECoxK/m S2BFLAKqEn9PL2IFsXkFbCWen3/LDmELSvyYfA+snllAS2L9zuNMELa8xOY1b4GGcgCdpC7x 6K8uxC49iatndjFDlIhI7HvxjhFkr4TANnaJx/deMUHsEpD4NvkQC0SvrMSmA8wQn0lKHFxx g2UCo9gsJJtnIdk8C8nmWUhWLGBkWcUomlqQXFCclF5kqlecmFtcmpeul5yfu4kREmkTdzDe P2B9iDEZaP1EZinR5HxgpOaVxBsamxlZmJqYGhuZW5qRJqwkzpv+KClISCA9sSQ1OzW1ILUo vqg0J7X4ECMTB6dUA6OF1G3960ZB6hU7log1uHJ2qmd4hwj7fw03e5gfpng/Stfi7tqgecL7 /mqldLTIT7r+1FdJVnNS0PHXPfq12xe3i86awHbZ59VV3ulnzoVtLfTg+lA4JcD670Hr/ieS +pcSAl3MavQ25G3rloh8Gc982jGyOCLZ5tJ1xatFe1b3zOQ+mhbXq8RSnJFoqMVcVJwIALNm t1/KAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsVy+t9jAd38+WeCDL6utbC4vPASq8WJvg+s FusevmCyWD//FpsDi8erC3dYPPq2rGL0OH5jO5PH501yASxRDYw2GamJKalFCql5yfkpmXnp tkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUA7lRTKEnNKgUIBicXFSvp2mCaEhrjp WsA0Ruj6hgTB9RgZoIGEdYwZq3/9YCp4y1rxfeErtgbGzyxdjJwcEgImElf/nWWDsMUkLtxb D2RzcQgJLGKUOPDuMSuE84tRYnX3LXaQKjYBNYkvXw6D2SICOhKTFvUwgxQxCzQzSmy+9gFs rLBAqMSv5ktgRSwCqhJ/Ty9iBbF5BWwlnp9/yw5hC0r8mHwPrJ5ZQEti/c7jTBC2vMTmNW+B hnIAnaQu8eivLsQuPYmrZ3YxQ5SISOx78Y5xAqPALCSTZiGZNAvJpFlIWhYwsqxiFE0tSC4o TkrPNdQrTswtLs1L10vOz93ECI7jZ1I7GFc2WBxiFOBgVOLhvaF2JkiINbGsuDL3EKMEB7OS CO+xbqAQb0piZVVqUX58UWlOavEhxmSgRycyS4km5wNTTF5JvKGxiZmRpZGZhZGJuTlpwkri vAdarQOFBNITS1KzU1MLUotgtjBxcEo1MFZf/mAovcTyHeMh+Xmzb+6tnXyHS7D4xBTBtcrN Ox99/firtKHLubAgdBfrlm0m9vuEKi9OUbE80iSx3ThLOt/jysXZwguDVRezb+DMKZ37uHhT wD9H9r4386+13ahrLXqcP59xicoj9tTa2693He+/5LXy3I45MuLKjgZZj9gXvd43IauX/ZIS S3FGoqEWc1FxIgA9bGpMJwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/asiliantfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/asiliantfb.c b/drivers/video/asiliantfb.c index d611f1a..7e8ddf0 100644 --- a/drivers/video/asiliantfb.c +++ b/drivers/video/asiliantfb.c @@ -589,7 +589,6 @@ static void asiliantfb_remove(struct pci_dev *dp) fb_dealloc_cmap(&p->cmap); iounmap(p->screen_base); release_mem_region(pci_resource_start(dp, 0), pci_resource_len(dp, 0)); - pci_set_drvdata(dp, NULL); framebuffer_release(p); }