From patchwork Wed Jan 8 00:45:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3450861 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 463F59F374 for ; Wed, 8 Jan 2014 00:45:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8357520121 for ; Wed, 8 Jan 2014 00:45:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A628220120 for ; Wed, 8 Jan 2014 00:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbaAHAp5 (ORCPT ); Tue, 7 Jan 2014 19:45:57 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:42666 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbaAHAp4 (ORCPT ); Tue, 7 Jan 2014 19:45:56 -0500 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MZ200GRM4SJBZ00@mailout2.samsung.com> for linux-fbdev@vger.kernel.org; Wed, 08 Jan 2014 09:45:55 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 69.6A.12635.3CF9CC25; Wed, 08 Jan 2014 09:45:55 +0900 (KST) X-AuditID: cbfee68d-b7fcd6d00000315b-cf-52cc9fc3f4c5 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 44.50.28157.3CF9CC25; Wed, 08 Jan 2014 09:45:55 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MZ200JBA4SJC150@mmp2.samsung.com>; Wed, 08 Jan 2014 09:45:55 +0900 (KST) From: Jingoo Han To: 'Tomi Valkeinen' Cc: linux-fbdev@vger.kernel.org, 'Jean-Christophe PLAGNIOL-VILLARD' , 'Jingoo Han' , 'Antonino Daplas' References: <001901cf0c0a$cb48b5e0$61da21a0$%han@samsung.com> In-reply-to: <001901cf0c0a$cb48b5e0$61da21a0$%han@samsung.com> Subject: [PATCH RESEND 3/4] video: rivafb: remove unnecessary pci_set_drvdata() Date: Wed, 08 Jan 2014 09:45:55 +0900 Message-id: <001b01cf0c0a$fd363c30$f7a2b490$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac8MCsswVut/rfVlTMmgQ3JkQXU43QAAB7iA Content-language: ko x-cr-hashedpuzzle: AaYD A2BP D4tt G43+ JE85 NxQh XXvX gVs8 jIIP k4Es q3YF uOp6 vDLD y6zz z+1i 3kz+; 5; YQBkAGEAcABsAGEAcwBAAGcAbQBhAGkAbAAuAGMAbwBtADsAagBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA7AGwAaQBuAHUAeAAtAGYAYgBkAGUAdgBAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcABsAGEAZwBuAGkAbwBqAEAAagBjAHIAbwBzAG8AZgB0AC4AYwBvAG0AOwB0AG8AbQBpAC4AdgBhAGwAawBlAGkAbgBlAG4AQAB0AGkALgBjAG8AbQA=; Sosha1_v1; 7; {6DC481B3-3DA4-4C5D-9D11-A17DED613D2A}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Wed, 08 Jan 2014 00:45:47 GMT; WwBQAEEAVABDAEgAIABSAEUAUwBFAE4ARAAgADMALwA0AF0AIAB2AGkAZABlAG8AOgAgAHIAaQB2AGEAZgBiADoAIAByAGUAbQBvAHYAZQAgAHUAbgBuAGUAYwBlAHMAcwBhAHIAeQAgAHAAYwBpAF8AcwBlAHQAXwBkAHIAdgBkAGEAdABhACgAKQA= x-cr-puzzleid: {6DC481B3-3DA4-4C5D-9D11-A17DED613D2A} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsVy+t8zY93D888EGaz4rmPxs/sLm8XlhZdY LU70fWC1WPfwBZPF+vm32BxYPXbOusvu8erCHRaPvi2rGD2O39jO5PF5k1wAaxSXTUpqTmZZ apG+XQJXxuarL5gLtrFWvJ3Vy97AuJ+li5GTQ0LAROLzmytQtpjEhXvr2boYuTiEBJYxSny8 cZgVpmjZpsdQiemMEj/e9zBBOL8YJU5tn8cMUsUmoCbx5cthdhBbREBHYtKiHmaQImaBVYwS F3a1MIEkhARsJZbung7WwClgJ3G8+QkbiC0s4C9x9sNsRhCbRUBVov/PT7B6XqD6I/vusEDY ghI/Jt8Ds5kFtCTW7zzOBGHLS2xe8xZoJgfQqeoSj/7qQtxgJPHu4VM2iBIRiX0v3jGC3CMh cIVV4sij41A/m0r0TT4AlfjJLnHt4lkmiCMEJL5NPsQCMVRWYtMBZoh6SYmDK26wTGCUmoXk pFlITpqF5KRZSHYvYGRZxSiaWpBcUJyUXmSoV5yYW1yal66XnJ+7iRES3707GG8fsD7EmAy0 fiKzlGhyPjA95JXEGxqbGVmYmpgaG5lbmpEmrCTOm/QwKUhIID2xJDU7NbUgtSi+qDQntfgQ IxMHp1QD49oZim+S14UUTt3wo3ihj8/xjXVZ90PMr5q/3hYmcP3Qa+0m0Thbb51W147j/2Z+ u+/3aPr1mBOzZLe4fdmw9FzTi7zVDuIN+e4/Pu14ap26gr9q8iq+/+I7frWUpYrqzbDim2bn rXfnuXduRCV/0lXdxTu3Jx4Xv1FxufaCCfMt1evb07sXpiixFGckGmoxFxUnAgAHpTzuBQMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPKsWRmVeSWpSXmKPExsVy+t9jQd3D888EGbSv0bT42f2FzeLywkus Fif6PrBarHv4gsli/fxbbA6sHjtn3WX3eHXhDotH35ZVjB7Hb2xn8vi8SS6ANaqB0SYjNTEl tUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaLuSQlliTilQKCCx uFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPz1RfMBdtYK97O6mVvYNzP0sXIySEhYCKx bNNjNghbTOLCvfVANheHkMB0Rokf73uYIJxfjBKnts9jBqliE1CT+PLlMDuILSKgIzFpUQ8z SBGzwCpGiQu7WphAEkICthJLd08Ha+AUsJM43vwEbIWwgL/E2Q+zGUFsFgFVif4/P8HqeYHq j+y7wwJhC0r8mHwPzGYW0JJYv/M4E4QtL7F5zVugmRxAp6pLPPqrC3GDkcS7h0/ZIEpEJPa9 eMcIco+EwBVWiSOPjkO9aSrRN/kA4wRGkVlIVsxCsmIWkhWzkMxawMiyilE0tSC5oDgpPddI rzgxt7g0L10vOT93EyM4eTyT3sG4qsHiEKMAB6MSD+8NtTNBQqyJZcWVuYcYJTiYlUR4j3UD hXhTEiurUovy44tKc1KLDzEmA0NgIrOUaHI+MLHllcQbGpuYGVkamVkYmZibkyasJM57sNU6 UEggPbEkNTs1tSC1CGYLEwenVAPjalZJb6Po9au3bvb1ffhlxz3elmT7yoqnR3m2rKsp092i WZIrEHBre8upmgNM61YGbHG8zfux5GfiwuK9ty5VXMpZdsVoSppK5FzWpTY6Iukr3VQdJVhY GR78OvA99rSYZNKpOcLb34rF9FyvcJvun1CiJL1oPoMD693jVYrtaoeuMH+PjdigxFKckWio xVxUnAgAdGDCEGIDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/riva/fbdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/riva/fbdev.c b/drivers/video/riva/fbdev.c index a5514ac..8a8d7f0 100644 --- a/drivers/video/riva/fbdev.c +++ b/drivers/video/riva/fbdev.c @@ -2128,7 +2128,6 @@ static void rivafb_remove(struct pci_dev *pd) pci_release_regions(pd); kfree(info->pixmap.addr); framebuffer_release(info); - pci_set_drvdata(pd, NULL); NVTRACE_LEAVE(); }