From patchwork Thu Sep 12 06:52:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2876311 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EF77CBF43F for ; Thu, 12 Sep 2013 06:52:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4542D2021E for ; Thu, 12 Sep 2013 06:52:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61EF2202C8 for ; Thu, 12 Sep 2013 06:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577Ab3ILGwe (ORCPT ); Thu, 12 Sep 2013 02:52:34 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:40465 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932154Ab3ILGwb (ORCPT ); Thu, 12 Sep 2013 02:52:31 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT000INV33AB8N0@mailout2.samsung.com> for linux-fbdev@vger.kernel.org; Thu, 12 Sep 2013 15:52:30 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id DC.D6.29948.EA461325; Thu, 12 Sep 2013 15:52:30 +0900 (KST) X-AuditID: cbfee691-b7f4a6d0000074fc-6a-523164ae3ee8 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id EA.BE.05832.EA461325; Thu, 12 Sep 2013 15:52:30 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT0002YH33IG5H0@mmp1.samsung.com>; Thu, 12 Sep 2013 15:52:30 +0900 (KST) From: Jingoo Han To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: 'Tomi Valkeinen' , linux-fbdev@vger.kernel.org, 'Jingoo Han' , 'Russell King' References: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> In-reply-to: <001a01ceaf84$32c52d90$984f88b0$%han@samsung.com> Subject: [PATCH 04/21] video: cyber2000fb: remove unnecessary pci_set_drvdata() Date: Thu, 12 Sep 2013 15:52:30 +0900 Message-id: <001e01ceaf84$a6b29b70$f417d250$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6vhDKuTCwbnQ4aTDC9KoLwWMziagAAF1xg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsVy+t8zI911KYZBBjv+KVpcXniJ1eJE3wdW i9uXeS3WPXzBZLF+/i02B1aPluYeNo9XF+6wePRtWcXocfzGdiaPz5vkAlijuGxSUnMyy1KL 9O0SuDIapl9kKpjDVrFsxUa2BsZ/LF2MnBwSAiYS9/+8Y4KwxSQu3FvP1sXIxSEksIxR4sqS ZWwwRdP2XGKGSCxilJi3+h4jhPOLUeLNubmsIFVsAmoSX74cZgexRQTsJBZevMQKUsQsMINR Yln7T7AiIQFbiaVvboPt5gQq+nJsIdgKYQF/iVUnJoPVsAioSiz5MhFsEC9Q/b+FlxghbEGJ H5PvgfUyC2hJrN95nAnClpfYvOYt0HkcQKeqSzz6qwtxg5HE58ffGCFKRCT2vXgHdrSEwC12 iWlbnrBD7BKQ+Db5EAtEr6zEpgPMEB9LShxccYNlAqPELCSbZyHZPAvJ5llIVixgZFnFKJpa kFxQnJReZKpXnJhbXJqXrpecn7uJERKrE3cw3j9gfYgxGWj9RGYp0eR8YKznlcQbGpsZWZia mBobmVuakSasJM6r3mIdKCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoHR9/ipxKmvpLQ9Fr8X mprAPHc36999OTfktRezrPGcuOFxi3ojd4qdzsyoiHMWESfTjuzYV+Ast9HE4SrH2lXxJnd5 Enj3XG3cI2ObwsjDcWTCtwYVaYHzGlHzJF6vVZdQuXa6I8Vp57IcB911Er3XM6ft2Xhog31f TKnfCY+wbbfnqk6rYwlTYinOSDTUYi4qTgQAXAvQd+sCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKKsWRmVeSWpSXmKPExsVy+t9jAd11KYZBBjd3yFlcXniJ1eJE3wdW i9uXeS3WPXzBZLF+/i02B1aPluYeNo9XF+6wePRtWcXocfzGdiaPz5vkAlijGhhtMlITU1KL FFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4CWKymUJeaUAoUCEouL lfTtME0IDXHTtYBpjND1DQmC6zEyQAMJ6xgzGqZfZCqYw1axbMVGtgbGfyxdjJwcEgImEtP2 XGKGsMUkLtxbz9bFyMUhJLCIUWLe6nuMEM4vRok35+ayglSxCahJfPlymB3EFhGwk1h48RIr SBGzwAxGiWXtP8GKhARsJZa+uQ22ghOo6MuxhWwgtrCAv8SqE5PBalgEVCWWfJkINogXqP7f wkuMELagxI/J98B6mQW0JNbvPM4EYctLbF7zFuhUDqBT1SUe/dWFuMFI4vPjb4wQJSIS+168 Y5zAKDQLyaRZSCbNQjJpFpKWBYwsqxhFUwuSC4qT0nON9IoTc4tL89L1kvNzNzGCE8Ez6R2M qxosDjEKcDAq8fB2zDIIEmJNLCuuzD3EKMHBrCTCG29uGCTEm5JYWZValB9fVJqTWnyIMRno 0YnMUqLJ+cAklVcSb2hsYmZkaWRmYWRibk6asJI478FW60AhgfTEktTs1NSC1CKYLUwcnFIN jHzLPK9+Tvdrtf186bjbmpk15+J9Si4ftRZvrXm4/vPeSV+nfJUQ/ntUb9JM8f+7Hb+eDmqy K4pZ8nDFpf25Ksf3pQdte6k4YS/Hkl1hPtuqxKSbGv049qnreLOFt/VzZDp9su684Xqwsalq /1b5SZdD1qvNmpB6JaSi0SunNHH9GxP2lwdd85RYijMSDbWYi4oTARCdpmJIAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/video/cyber2000fb.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/video/cyber2000fb.c b/drivers/video/cyber2000fb.c index e78d9f2..42da9c8 100644 --- a/drivers/video/cyber2000fb.c +++ b/drivers/video/cyber2000fb.c @@ -1874,11 +1874,6 @@ static void cyberpro_pci_remove(struct pci_dev *dev) iounmap(cfb->region); cyberpro_free_fb_info(cfb); - /* - * Ensure that the driver data is no longer - * valid. - */ - pci_set_drvdata(dev, NULL); if (cfb == int_cfb_info) int_cfb_info = NULL;